Skip to content

feat(composer): add support for attachments in drafts#5794

Merged
andybalaam merged 1 commit intomatrix-org:mainfrom
Johennes:johannes/attachment-drafts
Oct 21, 2025
Merged

feat(composer): add support for attachments in drafts#5794
andybalaam merged 1 commit intomatrix-org:mainfrom
Johennes:johannes/attachment-drafts

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

@Johennes Johennes commented Oct 20, 2025

This adds support for storing attachments with composer drafts. The API allows for multiple attachments in the draft. I believe this is ok, because the SDK doesn't provide more functionality than saving and loading the draft. It is up to the consuming client to decide how to use it. It may limit its usage to a single attachment, send multiple attachments as individual events or use MSC4274 galleries.

  • Public API changes documented in changelogs (optional)

@Johennes Johennes force-pushed the johannes/attachment-drafts branch from 8675b4b to 67a9489 Compare October 20, 2025 19:00
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/attachment-drafts branch from 67a9489 to cf6a2e8 Compare October 20, 2025 19:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 20, 2025

CodSpeed Performance Report

Merging #5794 will not alter performance

Comparing Johennes:johannes/attachment-drafts (cf6a2e8) with main (430304f)

Summary

✅ 50 untouched

@Johennes Johennes marked this pull request as ready for review October 20, 2025 19:18
@Johennes Johennes requested a review from a team as a code owner October 20, 2025 19:18
@Johennes Johennes requested review from andybalaam and removed request for a team October 20, 2025 19:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.46%. Comparing base (430304f) to head (cf6a2e8).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5794   +/-   ##
=======================================
  Coverage   88.45%   88.46%           
=======================================
  Files         360      360           
  Lines      100328   100344   +16     
  Branches   100328   100344   +16     
=======================================
+ Hits        88749    88765   +16     
+ Misses       7413     7412    -1     
- Partials     4166     4167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@andybalaam andybalaam merged commit 34d71b0 into matrix-org:main Oct 21, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants