feat(composer): add support for attachments in drafts#5794
Merged
andybalaam merged 1 commit intomatrix-org:mainfrom Oct 21, 2025
Merged
feat(composer): add support for attachments in drafts#5794andybalaam merged 1 commit intomatrix-org:mainfrom
andybalaam merged 1 commit intomatrix-org:mainfrom
Conversation
8675b4b to
67a9489
Compare
Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
67a9489 to
cf6a2e8
Compare
CodSpeed Performance ReportMerging #5794 will not alter performanceComparing Summary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5794 +/- ##
=======================================
Coverage 88.45% 88.46%
=======================================
Files 360 360
Lines 100328 100344 +16
Branches 100328 100344 +16
=======================================
+ Hits 88749 88765 +16
+ Misses 7413 7412 -1
- Partials 4166 4167 +1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for storing attachments with composer drafts. The API allows for multiple attachments in the draft. I believe this is ok, because the SDK doesn't provide more functionality than saving and loading the draft. It is up to the consuming client to decide how to use it. It may limit its usage to a single attachment, send multiple attachments as individual events or use MSC4274 galleries.