Skip to content

Add better logging for handling invites. #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Half-Shot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add better logging for handling invites. #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Bridge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,23 +1242,32 @@ export class Bridge {
roomId: string,
event: MatrixEvent<MatrixMemberContent>,
) {
log.debug(
`Got invite roomId=${roomId} from=${event.sender} to=${event.state_key}`,
);
if (this.as.isNamespacedUser(event.sender)) {
log.debug(
`Rejecting invite as sender is in our namespace`,
Copy link
Copy Markdown
Member

@jaywink jaywink Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Rejecting invite as sender is in our namespace`,
`Rejecting invite to ${roomId} as sender ${event.sender} is in our namespace`,

More context in the log line itself, to help with searching individual lines

);
/* Do not handle invites from our users */
return;
}
const invitedUserId = event.state_key;
if (!invitedUserId) {
log.debug(
`Rejecting invite state key was empty!`,
Copy link
Copy Markdown
Member

@jaywink jaywink Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Rejecting invite state key was empty!`,
`Rejecting invite from ${event.sender} to ${roomId} as state key (invited user) is empty!`,

More context in the log line itself, to help with searching individual lines

);
return;
}
log.info(
`Got invite roomId=${roomId} from=${event.sender} to=${invitedUserId}`,
`Processing invite from ${event.sender} to ${roomId} for ${invitedUserId}`,
);

const botUser = this.botUsersManager.getBotUser(invitedUserId);
if (!botUser) {
// We got an invite but it's not a configured bot user, must be for a ghost user
log.debug(
`Rejecting invite to room ${roomId} for ghost user ${invitedUserId}`,
`Rejecting invite to room ${roomId} for non-bot user ${invitedUserId}`,
Copy link
Copy Markdown
Member

@jaywink jaywink Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Rejecting invite to room ${roomId} for non-bot user ${invitedUserId}`,
`Rejecting invite from ${event.sender} to room ${roomId} for non-bot user ${invitedUserId}`,

More context in the log line itself, to help with searching individual lines

);
const client = this.as.getIntentForUserId(invitedUserId).underlyingClient;
return client.leaveRoom(roomId, "Bridge does not support DMing ghosts.");
Expand Down
Loading