Skip to content

Add Description Fields and Change Helptexts#251

Merged
lachiebol merged 11 commits into
5.x-devfrom
PG-5068-change-inline-helptexts
May 11, 2026
Merged

Add Description Fields and Change Helptexts#251
lachiebol merged 11 commits into
5.x-devfrom
PG-5068-change-inline-helptexts

Conversation

@maxtaube
Copy link
Copy Markdown
Contributor

@maxtaube maxtaube commented May 4, 2026

Description

Please reference the Ticket description and attached Document for the Tickets in Jira.

  • adds an inline helptext to the custom alert form name
  • adds a description field to custom alert (creation form)
  • adds api tests
  • adds model updates + migrations
  • removes deprecated function call

Issue No

  • Fixes #PG-5068
  • Fixes #PG-5021

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔/✖/NA] New test case added/updated?
  • [✔] Are all newly added texts included via translation?
  • [✔/✖/NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [✔/✖/NA] Documentation updated?

@maxtaube maxtaube self-assigned this May 4, 2026
@AltamashShaikh AltamashShaikh requested a review from a team May 6, 2026 03:38
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this was ready for review? But in general LGTM 👍 Just a note around API documentation

Also curious, do we know what this new description will be used for? Currently it's only displayed in the edit/create pages. Not on the ticket but maybe something to check with PO

Comment thread API.php
@maxtaube maxtaube changed the title Add inline helptext for name, add description field, add tests, add migration Add description field and update helptexts May 7, 2026
@maxtaube maxtaube changed the title Add description field and update helptexts Add Description Fields and Change Helptexts May 8, 2026
Copy link
Copy Markdown
Contributor

@lachiebol lachiebol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes look good :)

Apologies, missed this in the initial review

Comment thread CHANGELOG.md Outdated
## Changelog

* 5.2.6 - 2026-04-27 - Updated API documentation
* 5.3.0 - 2026-05-04 - Added alert description and helptexts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add 5.2.6 - 2026-04-27 - Updated API documentation back in

Also we'll need to update the release date for 5.3.0. @AltamashShaikh could this go out today? Maybe @maxtaube can release this one if the PR looks all good

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lachiebol Fixed the data, please check and reapprove

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AltamashShaikh Good to merge?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lachiebol If everything is working fine, yes 👍

@lachiebol lachiebol merged commit 291a6b3 into 5.x-dev May 11, 2026
9 checks passed
@lachiebol lachiebol deleted the PG-5068-change-inline-helptexts branch May 11, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants