fix: ApplicationDriver -> StandataDriver rename in standalone demo - #11
Merged
Conversation
Same root cause as ave#10/move#7: standata renamed ApplicationDriver (class) to StandataDriver (default export). This was already flagged in an earlier sweep but the fix wasn't applied when jove's own dependency-bump PR (#10) went through - npm test doesn't build the standalone bundle, so it broke deploy-bundle once standata was bumped to its real published version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same root cause as mat3ra/ave#10 and mat3ra/move#7: `standata` renamed `ApplicationDriver`
(class) to `StandataDriver` (default export). `npm test` doesn't build the standalone
bundle, so this broke `deploy-bundle` once #10 bumped `standata` to its real published
version:
```
[vite]: Rollup failed to resolve import "@mat3ra/standata/dist/js/ApplicationDriver"
```
Test plan