Disable now useless 8-bit mode - #1380
Open
z3bra wants to merge 1 commit into
Open
Conversation
Enabling 8-bit mode was rendered useless when switching to libtermkey as the input handler. This causes issues with terminals honoring the `smm` property (metaSendsEscape) by stripping the Alt sequence.
rnpnr
reviewed
Jul 29, 2026
rnpnr
left a comment
rnpnr
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the patch!
Can some other people confirm if this doesn't cause issues?
I never use the curses backend (and would like to remove it after fixing some lingering bugs) so I am unlikely to notice any issues even if I switch just for the purpose of testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling 8-bit mode was rendered useless when switching to libtermkey as the input handler. This also causes issues with terminals honoring the
smmproperty (metaSendsEscape) by stripping the Alt sequence and should thus be removed.Fixes #1252