Repository navigation
docs(solutions): refresh stale learnings and consolidate superseded docs - #1670
Merged
Merged
Conversation
Updates 11 learnings whose references drifted, consolidates the gateway --build docs into the off-droplet build practice and the three mention-loop docs into one, replaces the SPA catch-all and S3 key-layout learnings with current guidance, and repoints links to the removed docs.
fro-bot
approved these changes
Oct 24, 2026
fro-bot
left a comment
fro-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS
Reviewed the documentation diff and checked the principal operational claims against the current deploy code, workflows, and configuration. No blocking issues found.
Blocking issues
None
Non-blocking concerns
docs/plans/2026-06-01-001-feat-umami-postgres-major-upgrade-plan.mdstill references the deletedgateway-deploy-stale-image-2026-05-31.mdat lines 66 and 226. Repoint both references to the consolidated off-droplet build document.
Missing tests
None. Documentation-only changes; git diff --check passed. Runtime tests were not run.
Risk assessment (LOW) + rationale
No executable code, deployment configuration, permissions, or secrets changed. The remaining stale references affect documentation navigation only.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | marcusrbrown/infra |
| Run ID | 40056276883 |
| Cache | hit |
| Session | ses_e9427d597ffeZhTpTa8Vf6hEDt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshes
docs/solutions/against the current code.Replaced (the old guidance no longer matched the code):
best-practices/dashboard-app-owns-routing-caddy-proxy-only-2026-10-24.md: the app owns routing, and Caddy only splits/operator/*from everything else.integration-issues/agent-s3-iam-layout-drift-from-action-2026-08-03.md. It covers both IAM incidents and the current rule: only a layout change bumps the layout label and the IAM grants.Consolidated:
integration-issues/gateway-mention-loop-stalls-2026-06-03.md. That doc carries a timeline of each layer and where its fix lives now. Claims that are no longer true were dropped: holding the old pin, no readiness timeout setting, clones wiped on every deploy, and hard-coded model IDs.needs:drift.Updated (11 docs): stale file and line references, the approval-vs-cancel heading in the approval-gated cancellation doc, which now also points to the cancel-superseded workflow, raw
ssh-keyscansnippets now pointing topinHostKeys, Caddy references without a version,COMPOSE_WAIT_TIMEOUT_SECONDS, and closed upstream issues.Every link to a removed doc in
docs/,ARCHITECTURE.mdand the plans is repointed to its successor.