Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
=======================================
Coverage 98.85% 98.85%
=======================================
Files 3 3
Lines 174 175 +1
Branches 54 55 +1
=======================================
+ Hits 172 173 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
CC: @wayofthefuture |
Collaborator
Author
|
This is discusses as an option to solve: It's a lot simpler than the other options I tried. |
mwilsnd
approved these changes
Feb 23, 2026
Collaborator
mwilsnd
left a comment
There was a problem hiding this comment.
Looks reasonable to me, agreed this should be revisited once MVT matures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a json prefix option to allow parsing it back when needed.
Since objects are json.strigified, adding a prefix will allow finding where an object was stringified and parse it back to json.
This is a hack, but other alternatives are more complicated and I'm not sure are better.
In theory, when MLT will support nested properties we can remove this option.