Skip to content

Json prefix parameter#28

Merged
HarelM merged 4 commits intomaplibre:mainfrom
HarelM:add-json-prefix
Feb 23, 2026
Merged

Json prefix parameter#28
HarelM merged 4 commits intomaplibre:mainfrom
HarelM:add-json-prefix

Conversation

@HarelM
Copy link
Copy Markdown
Collaborator

@HarelM HarelM commented Feb 23, 2026

This adds a json prefix option to allow parsing it back when needed.
Since objects are json.strigified, adding a prefix will allow finding where an object was stringified and parse it back to json.
This is a hack, but other alternatives are more complicated and I'm not sure are better.
In theory, when MLT will support nested properties we can remove this option.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (9fda752) to head (12f9d57).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files           3        3           
  Lines         174      175    +1     
  Branches       54       55    +1     
=======================================
+ Hits          172      173    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM HarelM requested a review from mwilsnd February 23, 2026 16:39
@HarelM
Copy link
Copy Markdown
Collaborator Author

HarelM commented Feb 23, 2026

CC: @wayofthefuture

@HarelM HarelM requested a review from louwers February 23, 2026 16:40
@HarelM
Copy link
Copy Markdown
Collaborator Author

HarelM commented Feb 23, 2026

This is discusses as an option to solve:

It's a lot simpler than the other options I tried.

Copy link
Copy Markdown
Collaborator

@mwilsnd mwilsnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, agreed this should be revisited once MVT matures.

@HarelM HarelM merged commit a249245 into maplibre:main Feb 23, 2026
3 checks passed
@HarelM HarelM deleted the add-json-prefix branch February 23, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants