Skip to content

refactor: webgl isolation#7422

Merged
birkskyum merged 12 commits intomainfrom
webgl-isolation
Apr 7, 2026
Merged

refactor: webgl isolation#7422
birkskyum merged 12 commits intomainfrom
webgl-isolation

Conversation

@birkskyum
Copy link
Copy Markdown
Member

@birkskyum birkskyum commented Apr 6, 2026

  • rename /gl to /webgl
  • move all webgl draw files to /webgl/draw
  • move all webgl program files to /webgl/program/
  • updates all the imports in the remaining files
  • update painter to use a drawFunctions object, so for now draw.circle will reach the webgl drawCircle, but it gives the option for us to introduce a webgpu draw function.

Related to

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@birkskyum birkskyum changed the title chore: webgl isolation refactor: webgl isolation Apr 6, 2026
@birkskyum birkskyum requested a review from HarelM April 6, 2026 23:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (789b3da) to head (e41a3c5).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7422   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files         288      289    +1     
  Lines       23998    24001    +3     
  Branches     5095     5095           
=======================================
+ Hits        22286    22289    +3     
  Misses       1712     1712           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/render/painter.ts Outdated
Copy link
Copy Markdown
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a minor comment, otherwise looks good.

@birkskyum birkskyum merged commit 9adb85f into main Apr 7, 2026
24 checks passed
@birkskyum birkskyum deleted the webgl-isolation branch April 7, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants