chore: add logical-assignment-operators#7409
Open
CommanderStorm wants to merge 6 commits intomaplibre:mainfrom
Open
chore: add logical-assignment-operators#7409CommanderStorm wants to merge 6 commits intomaplibre:mainfrom
CommanderStorm wants to merge 6 commits intomaplibre:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7409 +/- ##
==========================================
- Coverage 92.86% 92.60% -0.26%
==========================================
Files 288 288
Lines 23998 23966 -32
Branches 5095 5086 -9
==========================================
- Hits 22286 22194 -92
- Misses 1712 1772 +60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
HarelM
reviewed
Apr 5, 2026
HarelM
reviewed
Apr 5, 2026
HarelM
reviewed
Apr 5, 2026
HarelM
reviewed
Apr 5, 2026
HarelM
reviewed
Apr 5, 2026
| if (this.imageAtlas) { | ||
| this.imageAtlas = null; | ||
| } | ||
| this.imageAtlas &&= null; |
Collaborator
There was a problem hiding this comment.
Just = null without the if or &&?
HarelM
reviewed
Apr 5, 2026
| if (this.dashPositions) { | ||
| this.dashPositions = null; | ||
| } | ||
| this.dashPositions &&= null; |
HarelM
reviewed
Apr 5, 2026
| if (this._frameId) { | ||
| this._frameId = null; | ||
| } | ||
| this._frameId &&= null; |
Collaborator
There was a problem hiding this comment.
Maybe better to set it to false as this is a boolean, or even change its name to indicate it's not holding an id.
Collaborator
|
Thanks! Done my review, looks good overall, added a few comments. |
CommanderStorm
commented
Apr 5, 2026
CommanderStorm
commented
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplifies the code, but won't make it shorter until #7404
logical assigment is es2021