Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7078 +/- ##
==========================================
+ Coverage 92.58% 92.61% +0.02%
==========================================
Files 289 289
Lines 24009 24007 -2
Branches 5088 5085 -3
==========================================
+ Hits 22228 22233 +5
+ Misses 1781 1774 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CommanderStorm
changed the title
HashHash
CommanderStorm
changed the title
HashHash
HarelM
reviewed
Feb 8, 2026
| test('invalidate hash, only one value', () => { | ||
| window.location.hash = '#24'; | ||
|
|
||
| expect(hash._isValidHash(hash._getCurrentHash())).toBeFalsy(); |
Collaborator
There was a problem hiding this comment.
I know this was not changed as part of this PR, but if there was a better way to test these internal methods without calling them explicitly, it would've been better...
Member
Author
There was a problem hiding this comment.
I don't know how to do this.
Given that we really want these to be correct, I think not using the public API is better here.
Also, the methods are not marked as private, so technically they are public api ^^
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
HarelM
reviewed
Feb 8, 2026
Collaborator
|
Sorry for spamming... I hope this is not too much... |
HarelM
approved these changes
Feb 9, 2026
bigmistqke
pushed a commit
to bigmistqke/maplibre-gl-js
that referenced
this pull request
Mar 20, 2026
* qee more tests * more tests * remove useless test * simplify a few more things * fix fmt * Update src/ui/hash.test.ts * Update src/ui/hash.test.ts * Apply suggestion from @CommanderStorm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Launch Checklist
I think the actual changes in #7073 are getting hard to review.
Lets pull the testcase changes out so that the actual changes are more obvious.