Repository navigation
Add test for flipped tile objects - #350
Merged
Merged
Conversation
The tile id and tileset location of tile objects were already covered by test_object_template_property, but the flip flags were not tested for objects anywhere (test_flipped only covers layer tiles). Closes #144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144.
Most of what that issue asks for turned out to already be covered:
test_object_template_propertyasserts the tile id,TilesetLocation::Map/Templatedistinction and tileset resolution for both direct and templated tile objects. The remaining gap was the flip flags, which no test asserted for tile objects (test_flippedonly covers layer tiles).Adds two flipped tile objects to
tiled_object_template.tmx(one flipped horizontally+vertically, one diagonally) and a test asserting the flags and tile id for those plus the unflipped object.