Repository navigation
Deprecate the values of ObjectShape::Point - #346
Merged
Merged
Conversation
They merely duplicate the object's x and y members, and the TMX <point> element has no attributes of its own. The variant itself remains; matching it with ObjectShape::Point(..) avoids the deprecation warnings. Closes #329
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values of
ObjectShape::Point(f32, f32)merely duplicate the object's ownxandymembers, and the TMX<point>element has no attributes of its own, so they were inconsistent with the other shape variants (see #329).Rust supports
#[deprecated]on individual tuple-variant fields, which gives exactly the behavior we want here:x/ymembers instead.ObjectShape::Point(..)stays warning-free, so consumers who don't rely on the redundant values are unaffected.The variant doc explains the migration, and the values can then be dropped entirely in the release after 0.16.
Closes #329