Skip to content

Modify pr build and test workflow to include macOS - #42031

Open
SilkeSchomann wants to merge 1 commit into
mainfrom
update_pr_workflow_for_macos
Open

Modify pr build and test workflow to include macOS#42031
SilkeSchomann wants to merge 1 commit into
mainfrom
update_pr_workflow_for_macos

Conversation

@SilkeSchomann

@SilkeSchomann SilkeSchomann commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description of work

Once mantidproject/dockerfiles#176 is merged and there is at least one macOS GitHub runner registered for the Mantid repo, this PR can be reviewed and merged. It modifies the PR build and test workflow so that macOS runners can be used.

  • This means it needs to differentiate between X64 and ARM64 architectures.
  • Just like Windows, macOS is excluded from ornl-next builds.
  • BUILD_THREADS had to be modified slightly for macOS, but stays the same for Windows and Linux.
  • In addition, unit test output for macOS is archived in a similar way as for the other OS.

To test:

Setup at least one macOS GitHub runner for the repo and run this workflow. Please note that without a macOS GitHub runner PR Build and Test / build-and-test (macOS, osx-arm64-ci, ARM64) (pull_request) cannot complete successfully.

This does not require release notes because it is a modification of our CI pipeline and not user-facing.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@github-actions github-actions Bot added this to the Release 7.0 milestone Aug 13, 2026
@SilkeSchomann SilkeSchomann added the DevOps Issues and pull requests related to DevOps label Aug 13, 2026
@SilkeSchomann
SilkeSchomann marked this pull request as ready for review August 14, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DevOps Issues and pull requests related to DevOps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant