Modify pr build and test workflow to include macOS - #42031
Open
SilkeSchomann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Once mantidproject/dockerfiles#176 is merged and there is at least one macOS GitHub runner registered for the Mantid repo, this PR can be reviewed and merged. It modifies the PR build and test workflow so that macOS runners can be used.
ornl-nextbuilds.BUILD_THREADShad to be modified slightly for macOS, but stays the same for Windows and Linux.To test:
Setup at least one macOS GitHub runner for the repo and run this workflow. Please note that without a macOS GitHub runner PR Build and Test / build-and-test (macOS, osx-arm64-ci, ARM64) (pull_request) cannot complete successfully.
This does not require release notes because it is a modification of our CI pipeline and not user-facing.
Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: