Add scheduled exit support#343
Open
MadMaxMangos wants to merge 4 commits into
Open
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 92 |
| Duplication | 5 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
billy1arm
requested changes
Jun 3, 2026
Member
billy1arm
left a comment
There was a problem hiding this comment.
There are two issues I see:
- Both will need to have the conf version numbers updated; these are in MangosParams.cmake
The format is normally in the format YYYYMMDD00
- Rather than those strings being in the conf file, they should be in the database mangos_strings as new entries and called from there; this allows for easy localisation.
billy1arm
requested changes
Jun 3, 2026
Member
billy1arm
left a comment
There was a problem hiding this comment.
can you change the starting id from 1717 to 1730 onwards to allow the same code to be used across the cores.
MangosThree has some additional messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add scheduled maintenance restart/shutdown support to mangosd
Adds disabled-by-default scheduled shutdown/restart support to mangosd, replacing the previous need for external Remote Admin scripts to drive weekly maintenance restarts.
Behavior:
ScheduledExitconfig support tomangosd.conf.dist.SERVER_MSG_CUSTOM/SMSG_SERVER_MESSAGE, so it appears in the same yellow server-message channel as built-in shutdown/restart countdowns rather than as a GM-style announce.Validation:
scheduled_exit_tests.exepassed.gameandmangosdrebuilt successfully.git diff --checkpassed.SERVER_MSG_CUSTOMbehavior verified against the 1.12.1 client handler andServerMessages.dbcrow 3%s.Notes:
This change is