-
Notifications
You must be signed in to change notification settings - Fork 26
Plane-EE: Add webhook consumer service #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akshat5302
wants to merge
6
commits into
master
Choose a base branch
from
add-webhook-consumer-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
50876f9
release: Update Plane version to `v2.5.3` in Chart.yaml, README.md, q…
akshat5302 c979542
Merge branch 'master' of https://github.com/makeplane/helm-charts
akshat5302 7098d4c
Merge branch 'master' of https://github.com/makeplane/helm-charts
akshat5302 1e893f8
Merge branch 'master' of https://github.com/makeplane/helm-charts
akshat5302 d7c23b0
feat: add webhook consumer service configuration and deployment
akshat5302 bf7d317
Merge branch 'master' of https://github.com/makeplane/helm-charts int…
akshat5302 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
charts/plane-enterprise/templates/config-secrets/webhook-consumer.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| {{- if .Values.services.webhook_consumer.enabled }} | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| namespace: {{ .Release.Namespace }} | ||
| name: {{ .Release.Name }}-webhook-consumer-vars | ||
| data: | ||
| WEBHOOK_QUEUE_NAME: {{ .Values.env.webhook_consumer_envs.queue_name | default "plane.webhook" | quote }} | ||
| WEBHOOK_PREFETCH_COUNT: {{ .Values.env.webhook_consumer_envs.prefetch_count | default 10 | quote }} | ||
| --- | ||
| {{- end }} |
77 changes: 77 additions & 0 deletions
77
charts/plane-enterprise/templates/workloads/webhook-consumer.deployment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| {{- if .Values.services.webhook_consumer.enabled }} | ||
| apiVersion: apps/v1 | ||
| kind: Deployment | ||
| metadata: | ||
| namespace: {{ .Release.Namespace }} | ||
| name: {{ .Release.Name }}-webhook-consumer-wl | ||
| {{- include "plane.labelsAndAnnotations" .Values.services.webhook_consumer }} | ||
| spec: | ||
| replicas: {{ .Values.services.webhook_consumer.replicas | default 1 }} | ||
| selector: | ||
| matchLabels: | ||
| app.name: {{ .Release.Namespace }}-{{ .Release.Name }}-webhook-consumer | ||
| template: | ||
| metadata: | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: | ||
| app.name: {{ .Release.Namespace }}-{{ .Release.Name }}-webhook-consumer | ||
| annotations: | ||
| timestamp: {{ now | quote }} | ||
| spec: | ||
| {{- include "plane.podScheduling" .Values.services.webhook_consumer }} | ||
| containers: | ||
| - name: {{ .Release.Name }}-webhook-consumer | ||
| imagePullPolicy: {{ .Values.services.api.pullPolicy | default "Always" }} | ||
| image: {{ .Values.services.api.image | default "makeplane/backend-commercial" }}:{{ .Values.planeVersion }} | ||
| stdin: true | ||
| tty: true | ||
| resources: | ||
| requests: | ||
| memory: {{ .Values.services.webhook_consumer.memoryRequest | default "500Mi" | quote }} | ||
| cpu: {{ .Values.services.webhook_consumer.cpuRequest | default "250m" | quote }} | ||
| limits: | ||
| memory: {{ .Values.services.webhook_consumer.memoryLimit | default "1000Mi" | quote }} | ||
| cpu: {{ .Values.services.webhook_consumer.cpuLimit | default "500m" | quote}} | ||
| readinessProbe: | ||
| exec: | ||
| command: | ||
| - sh | ||
| - -c | ||
| - pgrep -f "python" > /dev/null | ||
| initialDelaySeconds: 10 | ||
| failureThreshold: 3 | ||
| periodSeconds: 30 | ||
| successThreshold: 1 | ||
| timeoutSeconds: 5 | ||
| command: | ||
| - ./bin/docker-entrypoint-webhook-consumer.sh | ||
| envFrom: | ||
| - configMapRef: | ||
| name: {{ .Release.Name }}-webhook-consumer-vars | ||
| optional: false | ||
| - configMapRef: | ||
| name: {{ .Release.Name }}-app-vars | ||
| optional: false | ||
| - secretRef: | ||
| name: {{ if not (empty .Values.external_secrets.app_env_existingSecret) }}{{ .Values.external_secrets.app_env_existingSecret }}{{ else }}{{ .Release.Name }}-app-secrets{{ end }} | ||
| optional: false | ||
| - secretRef: | ||
| name: {{ if not (empty .Values.external_secrets.doc_store_existingSecret) }}{{ .Values.external_secrets.doc_store_existingSecret }}{{ else }}{{ .Release.Name }}-doc-store-secrets{{ end }} | ||
| optional: false | ||
| - secretRef: | ||
| name: {{ if not (empty .Values.external_secrets.opensearch_existingSecret) }}{{ .Values.external_secrets.opensearch_existingSecret }}{{ else }}{{ .Release.Name }}-opensearch-secrets{{ end }} | ||
| optional: false | ||
| {{- if .Values.services.silo.enabled }} | ||
| - secretRef: | ||
| name: {{ if not (empty .Values.external_secrets.silo_env_existingSecret) }}{{ .Values.external_secrets.silo_env_existingSecret }}{{ else }}{{ .Release.Name }}-silo-secrets{{ end }} | ||
| optional: false | ||
| {{- end }} | ||
| {{- if .Values.extraEnv }} | ||
| env: | ||
| {{- toYaml .Values.extraEnv | nindent 10 }} | ||
| {{- end }} | ||
|
|
||
| serviceAccount: {{ .Release.Name }}-srv-account | ||
| serviceAccountName: {{ .Release.Name }}-srv-account | ||
| --- | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the webhook consumer pull policy here.
Line 24 reads
services.api.pullPolicy, so the newservices.webhook_consumer.pullPolicysetting exposed invalues.yamland documented inREADME.mdis currently ignored. That makes this workload impossible to configure independently and can break clusters that rely onIfNotPresentorNeverfor just this consumer.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents