Repository navigation
Conversation
Signed-off-by: nana <823073145@qq.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zqchris
approved these changes
Oct 29, 2026
[Medium impact] 未发现阻止合并的问题。
|
added 2 commits
October 29, 2026 21:43
Signed-off-by: nana <823073145@qq.com>
Signed-off-by: nana <823073145@qq.com>
Contributor
Author
|
@greptileai Please review the latest changes at commit 80618eb. |
8 tasks done
Signed-off-by: nana <823073145@qq.com>
Contributor
Author
|
@greptileai Please review the latest changes at commit 5ed5b37. |
11 tasks done
Signed-off-by: nana <823073145@qq.com>
Contributor
Author
|
@greptileai Please review the latest changes at commit 6038970. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这次改了什么
摘要
手机群聊正文长按此前只弹出整段 Copy,无法选择部分文字。现在群聊复用任务内既有文本选择组件,iOS 显示系统选区、手柄和菜单,可以选中一小段再复制;Android 保留现有系统选择。
变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
MarkdownSelectableText/MarkdownSelectableSpan,由任务与群消息正文共用;覆盖自己的点名消息、伙伴 Markdown、列表、代码和表格文字;更新选择高亮守卫、产品规则和生成台账。UI 变化
当前主线同步实看(2026-10-30,
60389700dd)同步
main@694d5b5a,生产选字实现保持不变。下面为本地集成预览preview/mobile-7847-selection@e13187449的真实 Simulator 截图,仅裁剪到 QA 消息:系统菜单及双手柄只选中正文中的一个“群”字。本轮确认选区,未再次点击 Copy 或读取剪贴板。预览同时含 #7847,分支不推送,不进入本 PR。以下“我们”的复制验证与截图属于初始生产提交
7ad822c57的历史验收:iPhone 17 Pro / iOS 26.5 本地 Xcode Simulator,真实账号与群历史,Light;截图裁剪到 QA 演示消息的系统选区,没有使用 mock 页面。已确认仅复制选中的“我们”两个字。
DESIGN.md §14.5保留正文既有可点性语义,群内链接仍为只读文字;§5保留既有布局与点击目标;apps/mobile/docs/mobile-design-guide.md §3沿用原字号、行高和主题颜色,选区高亮交给系统。docs/product-rules/bot-group-chat.md §5已同步原生局部选择要求。没有新增控件、颜色、动效或原生依赖。怎么验证的
当前主线同步验证(2026-10-30,
60389700dd1beb583cbc8d0e17fba7725a8391fe)main@694d5b5a;唯一冲突为生成设计台账,使用正式脚本重生成。生产选择实现自动合并,保持本 PR 范围;merge-only,不增加既有 3 轮修复计数。e13187449:5 文件 296 项通过,5.43s,Mobile 类型检查通过;真实 Simulator 的 QA 正文局部选字、话题入口和详情已实看。.worktrees/mobile-7847-selection-preview,实际来源及 DEV build label 为preview/mobile-7847-selection@e13187449;iPhone 17 Pro / iOS 26.5 / Global /uiMock=false,原生指纹匹配。其他任务 Metro 和专用模拟器未动。自动验证(历史
5ed5b374,当前复跑见上节)测试价值:
BotGroupChatScreen.test.tsx:真实群聊页面入口,保留既有 113 项交互测试;共享选字组件新增原生依赖后,缺失的 UITextView / StyleSheet / 字体缩放适配导致 Linux、Windows CI 在收集阶段抛出Unexpected token typeof。本机复现失败后补齐 jsdom 原生表面,不 mock 群消息或共享选择组件,不新增或削弱断言。unit,单文件 3.39s。BotGroupMarkdownText.test.tsx:生产入口为BotGroupMarkdownText/BotGroupUserText。最小输入为带强调的正文与一条点名消息;旧版 iOS 走 RN Text,无法局部选择,原有测试只验证排版。以 native-carrier fake 验证 iOS 选择根和嵌套格式文本同属 UITextView、Android 保留 RN Text;实际手柄与复制由 Simulator 验收。unit,修复前 iOS 用例失败、修复后双端通过;单文件 1.20s。userMessageCollapse.test.ts:直接导入真实共享组件,原生表面 fake;保留巨型长消息展开后 RN Text 回退、普通文字继续 UITextView 的已有生产行为回归。旧位置函数抽取在搬迁后加载失败,现已改为真实组件入口,没有新增用例或源码字面断言。unit,18 项、单文件 1.43s。messageNativeLifecycleContracts.test.ts:原生选字、手势所有权等已有跨文件契约继续保留,选择组件相关检查读取新模块;Node 无法执行 UIKit,实际手柄由 Simulator 覆盖。guard,5 项、单文件 0.243s。messageSelectionHighlight.test.ts:保留 fix(mobile): 消息文本选中高亮回归系统默认 #1427 的跨文件原生选择高亮契约,把原有守卫覆盖移到共享组件;禁止逐 view 覆写不透明选中色。guard,最小输入为任一生产选择载体覆盖 selectionColor;单文件 0.235s。手工验证
F125D3B4-D465-4F9A-9F9E-E68770754604,com.xd.cindy,Global、真实账号、uiMock=false;生产 UI 在7ad822c57提交实看,后续三个提交只修正测试入口与原生表面适配,生产 UI 未变化。未执行的验证
80618eb9自动 review 为 5/5、原线程已回复并 Resolve,但该 head 的 Linux / Windows 群聊页面测试均在加载原生模块时失败;本轮已复现并修复测试适配。此历史轮次提交为5ed5b374a872a3fe861e1c94d0817c4c6108de26;当前提交与评分见上节。preview/mobile-7847-selection@b74a94ae7合并 feat(mobile): 补齐话题浏览、关注与贴回群聊交互 #7847 的话题和操作栏 UI 与本 PR 生产改动,真实 Simulator 已确认话题摘要、操作栏和原生选区共存;预览分支不推送、不进入本 PR,两个 PR 仍独立。fix-mobile-group-text-selection,独立 worktree.worktrees/mobile-group-text-selection;生产改动曾以fix-mobile-group-text-selection@7ad822c57验证原生选择。当时 Metro 8081 为上述历史兼容性预览preview/mobile-7847-selection@b74a94ae7;当前归属和实际验收见上节。风险
风险分类
影响与回滚
提交前检查
git commit -s,见 DCO)