refactor(AFC): Updating tooltips in AFC Print Dialog to show more information - #2598
jimmyjon711 wants to merge 4 commits into
Conversation
…ormation - Updated tooltips to show the same information as AfcPanelUnitLaneBody when hoving mouse over lane/spool - Added checkmark to lane thats currently selected when selecting the lane selection dropdown. - Added tooltip to show more information in the lane selection dropdown - Updated material checking so that PLA matches PLA+ and does not give warning. - Refactored code to use `getAfcLaneInfo` for both `StartPrintDialogAfcTool.vue` and `AfcPanelUnitLaneBody.vue` so that code was not duplicated since they both need the same information. Signed-off-by: Jim Madill <jcmadill1@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe English AFC start-print localization block retains ChangesAFC Start-Print Localization
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Jim Madill <jcmadill1@gmail.com>
|
thx for your PR. why didnt you use the |
@meteyou I guess it was more of I wasnt sure if you would be ok with me editing that since it seemed like a general component that could be used outside of AFC code, but if you would rather me edit it there(which makes sense to keep down on the redundant code) I can do that. |
|
@jimmyjon711 sry, in the video it looks identical to me (the pill with the filament type below). did i miss something? |
|
@meteyou so the file filament pill on the left didn't change, it's the lane tooltip on the right that changed to add more information about the filament for the lane that's loaded in the first video |
- Updating code to utilize gcodefiles-panel-table-row-file-metadata-filaments-badge panel so that code is not duplicated. - Fixed small bug with spool percentage when not using spoolman since AFC currently does not return `initial_weight` for some reason. Signed-off-by: Jim Madill <jcmadill1@gmail.com>
|
@meteyou Went back though and put Also found a bug and fixed where spool percentage was not calculated correctly when not using spoolman as AFC does not expose Edit: not a bug, I just have not added these variables in yet... AFCProject/AFC-Klipper-Add-On#727 |
- Disabling tooltip when spoolId is set to 0 - Returning empty string instead of `Unknown` when filament name is not set from AFC Signed-off-by: Jim Madill <jcmadill1@gmail.com>
|
I just merged & released the small bugfix. So you are save to release the new AFC update. The rest will come after my holidays... sry for the delay. |
|
Gonna break this PR into atleast two separate PRs |

Description
Updating AFC Print Dialog to match fluidd update that shows users more information and adds checkmark so its clear to the end user what lane is currently assigned to the T(n) tool.
Changes:
getAfcLaneInfofor bothStartPrintDialogAfcTool.vueandAfcPanelUnitLaneBody.vueso that code was not duplicated since they both need the same information.Note: Updates were done with help from claude and reviewed by me, please let me know if something was done wrong 😬
Related Tickets & Documents
None
Mobile & Desktop Screenshots/Recordings
Print Dialog Updates:
mainsail_print_dialog_update.mp4
Updates to AFC panel still look the same:
mainsail_afc_panel.mp4
[optional] Are there any post-deployment tasks we need to perform?
None