Skip to content

feat: Multi-Template Support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maheshrijal wants to merge 4 commits into from
Closed

feat: Multi-Template Support #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
028ca24
feat: implement multi-template support
maheshrijal Jan 2, 2026
d31c53e
fix: resolve PR feedback - fix template imports and pdf.js reference …
maheshrijal Jan 2, 2026
667823e
fix: update template test case to include required address fields
maheshrijal Jan 2, 2026
ccf990d
feat: move template selector to button row for better UX
maheshrijal Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,12 @@ <h3>Import / Export</h3>
</div>

<div class="button-row">
<select id="templateId"
style="padding: 0.6rem; border-radius: 0.375rem; border: 1.5px solid var(--border-light); margin-right: auto; cursor: pointer;"
aria-label="Select Invoice Template">
<option value="default">Default Standard</option>
<option value="minimal">Minimalist</option>
</select>
<button type="button" class="primary" onclick="generateBill()">Generate Bill</button>
<button type="button" class="secondary" onclick="downloadPDF()" id="downloadBtn"
style="display:none;">Download PDF</button>
Expand Down
7 changes: 7 additions & 0 deletions src/js/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,13 @@ function attachEventHandlers() {
syncFromForm({ render: shouldRender });
});

// Explicitly handle template change for immediate feedback
document.getElementById('templateId').addEventListener('change', () => {
if (isInvoiceVisible()) {
syncFromForm({ render: true });
}
});

document.getElementById('addItemBtn').addEventListener('click', () => {
addItemRow({ description: '', quantity: 1, unitPrice: 0 });
syncFromForm({ render: isInvoiceVisible() });
Expand Down
4 changes: 3 additions & 1 deletion src/js/modules/form.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ import { renderInvoice, isInvoiceVisible } from './invoice.js';
export function getDataFromForm() {
const settings = {
currency: getValue('currencyCode', 'INR').trim() || 'INR',
locale: 'en-IN'
locale: 'en-IN',
templateId: getValue('templateId', 'default')
};

const items = collectItemsFromForm(settings);
Expand Down Expand Up @@ -121,6 +122,7 @@ export function applyDataToForm(data, syncCallback) {
setValue('invoiceNumber', data.invoice?.number ?? '');

setValue('currencyCode', data.settings?.currency ?? 'INR');
setValue('templateId', data.settings?.templateId ?? 'default');

renderItemsForm(data.items || []);

Expand Down
7 changes: 7 additions & 0 deletions src/js/modules/invoice.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ export function isInvoiceVisible() {
*/
export function renderInvoice(data) {
const { settings, seller, billTo, invoice, items, totals } = data;
const templateId = settings.templateId || 'default';

const invoiceEl = document.getElementById('invoice');
// Remove existing template classes
invoiceEl.className = invoiceEl.className.replace(/invoice-template-[^\s]+/, '').trim();
// Add new template class
invoiceEl.classList.add(`invoice-template-${templateId}`);

setText('displaySellerName', seller.name);
setText('displaySellerAddress', seller.address || '');
Expand Down
233 changes: 4 additions & 229 deletions src/js/modules/pdf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,243 +3,18 @@
* PDF generation and sharing functionality using pdfmake
*/

import { getTemplate } from './templates/template-registry.js';

@greptile-apps greptile-apps Bot Jan 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: missing import for getDataFromForm which is used on lines 34 and 67

Suggested change
import { getTemplate } from './templates/template-registry.js';
import { getDataFromForm } from './form.js';
import { getTemplate } from './templates/template-registry.js';
Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/js/modules/pdf.js
Line: 6:6

Comment:
**syntax:** missing import for `getDataFromForm` which is used on lines 34 and 67

```suggestion
import { getDataFromForm } from './form.js';
import { getTemplate } from './templates/template-registry.js';
```

How can I resolve this? If you propose a fix, please make it concise.

import { getDataFromForm } from './form.js';
import { formatCurrency, formatDate } from './formatters.js';

/**
* Generate PDF Document Definition from data
* @param {Object} data - Invoice data
* @returns {Object} pdfmake document definition
*/
function generateDocumentDefinition(data) {
const { seller, billTo, invoice, items, totals, settings } = data;
const currency = settings.currency;
const locale = settings.locale;

// Helper to format currency
const fmt = (amount) => formatCurrency(amount, currency, locale);

// Prepare table body
const tableBody = [];

// Header
tableBody.push([
{ text: 'DESCRIPTION', style: 'tableHeader' },
{ text: 'QTY', style: 'tableHeader', alignment: 'center' },
{ text: 'UNIT PRICE', style: 'tableHeader', alignment: 'right' },
{ text: 'TOTAL', style: 'tableHeader', alignment: 'right' }
]);

// Items
items.forEach(item => {
tableBody.push([
{ text: item.description || '', style: 'tableCell' },
{ text: item.quantity, style: 'tableCell', alignment: 'center' },
{ text: fmt(item.unitPrice), style: 'tableCell', alignment: 'right' },
{ text: fmt(item.total), style: 'tableCell', alignment: 'right' }
]);
});

// Totals section (rows)
const totalsRows = [];

// Only show Subtotal if there are adjustments (tax or discount)
if (totals.taxAmount > 0 || totals.discount > 0) {
totalsRows.push([
{ text: 'Subtotal', alignment: 'right' },
{ text: fmt(totals.subtotal), alignment: 'right' }
]);

if (totals.taxAmount > 0) {
totalsRows.push([
{ text: `Tax (${totals.taxRate}%)`, alignment: 'right' },
{ text: fmt(totals.taxAmount), alignment: 'right' }
]);
}

if (totals.discount > 0) {
totalsRows.push([
{ text: 'Discount', alignment: 'right' },
{ text: `-${fmt(totals.discount)}`, alignment: 'right' }
]);
}
}

// Total Row
totalsRows.push([
{ text: 'Total', bold: true, fontSize: 12, alignment: 'right' },
{ text: fmt(totals.total), bold: true, fontSize: 12, alignment: 'right' }
]);

const invoiceNumber = invoice.number || 'draft';
const customerName = billTo.name || 'Customer';

return {
// Moderate margins: [left, top, right, bottom]
pageMargins: [30, 40, 30, 40],

info: {
title: `Invoice ${invoiceNumber}`,
author: seller.name || 'Rebill',
subject: `Invoice for ${customerName}`,
creator: 'Rebill - Invoice Generator'
},
content: [
// Header Section
{
columns: [
// Seller Info (Left)
{
width: '*',
stack: [
{ text: seller.name || 'Business Name', style: 'businessName' },
{ text: seller.address || '', style: 'normalText' },
seller.email ? { text: seller.email, style: 'normalText' } : null,
seller.phone ? { text: seller.phone, style: 'normalText' } : null
].filter(Boolean)
},
// Invoice Title & Meta (Right)
{
width: 'auto',
alignment: 'right',
stack: [
{ text: invoice.title || 'INVOICE', style: 'invoiceTitle' },
{
text: [
{ text: 'Invoice #: ', bold: true },
invoiceNumber
],
style: 'metaText'
},
{
text: [
{ text: 'Date: ', bold: true },
formatDate(invoice.date)
],
style: 'metaText'
},
invoice.dueDate ? {
text: [
{ text: 'Due Date: ', bold: true },
formatDate(invoice.dueDate)
],
style: 'metaText'
} : null
].filter(Boolean)
}
],
columnGap: 20,
marginBottom: 40
},

// Bill To Section
{
text: 'BILL TO',
style: 'sectionLabel',
marginBottom: 5
},
{
stack: [
{ text: customerName, style: 'customerName' },
{ text: billTo.address || '', style: 'normalText' },
billTo.email ? { text: billTo.email, style: 'normalText' } : null,
billTo.phone ? { text: billTo.phone, style: 'normalText' } : null
].filter(Boolean),
marginBottom: 40
},

// Items Table
{
table: {
headerRows: 1,
widths: ['*', 50, 80, 80],
body: tableBody
},
layout: {
hLineWidth: (i, node) => 0.5,
vLineWidth: (i, node) => 0.5,
hLineColor: (i, node) => '#E5E7EB',
vLineColor: (i, node) => '#E5E7EB',
paddingLeft: (i) => 8,
paddingRight: (i) => 8,
paddingTop: (i) => 4,
paddingBottom: (i) => 4
},
marginBottom: 20
},

// Totals
{
columns: [
{ width: '*', text: '' }, // Spacer
{
width: 'auto',
table: {
widths: ['auto', 100],
body: totalsRows
},
layout: {
// Add a top border line only above the last row (Total)
hLineWidth: (i, node) => {
const lastRowIndex = node.table.body.length;
return i === lastRowIndex - 1 ? 0.5 : 0;
},
vLineWidth: () => 0,
hLineColor: () => '#9CA3AF',
paddingLeft: () => 8,
paddingRight: () => 0,
paddingTop: (i, node) => {
const lastRowIndex = node.table.body.length;
return i === lastRowIndex - 1 ? 6 : 2;
},
paddingBottom: () => 2
}
}
],
marginBottom: 40
},

// Footer Section: Center aligned, standard font size, bold "Thank you"
{
stack: [
// Notes (Thank you message)
invoice.notes ? {
text: invoice.notes,
style: 'footerNote',
alignment: 'center',
marginBottom: 10
} : null,

// Instructions (Bank details etc)
invoice.instructions ? {
text: invoice.instructions,
style: 'footerText',
alignment: 'center'
} : null
].filter(Boolean)
}
].filter(Boolean),

styles: {
businessName: { fontSize: 18, bold: true, marginBottom: 4, color: '#111827' },
invoiceTitle: { fontSize: 24, bold: true, marginBottom: 8, color: '#111827' },
sectionLabel: { fontSize: 10, bold: true, color: '#6B7280', letterSpacing: 1, marginBottom: 4 },
customerName: { fontSize: 14, bold: true, marginBottom: 4, color: '#111827' },
normalText: { fontSize: 10, lineHeight: 1.4, color: '#4B5563' },
metaText: { fontSize: 10, marginBottom: 4, alignment: 'right', color: '#4B5563' },

// Table styles
tableHeader: { fontSize: 10, bold: true, color: '#111827', fillColor: '#F3F4F6', margin: [0, 2, 0, 2] },
tableCell: { fontSize: 10, color: '#111827', margin: [0, 2, 0, 2] },

// Footer styles
footerNote: { fontSize: 14, bold: true, color: '#111827' },
footerText: { fontSize: 10, color: '#111827', lineHeight: 1.5 }
},
defaultStyle: {
font: 'Roboto'
}
};
const templateId = data.settings?.templateId || 'default';
const template = getTemplate(templateId);
return template.generateDocumentDefinition(data);
}

/**
Expand Down
Loading