fix: mitigate httpoxy vulnerability (CVE-2016-5385) in nginx config#40680
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix: mitigate httpoxy vulnerability (CVE-2016-5385) in nginx config#40680lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mitigate the httpoxy vulnerability (CVE-2016-5385) in the sample Nginx configuration by clearing the
Proxyrequest header before it reaches PHP-FPM.Problem
When Nginx passes a request to PHP-FPM via FastCGI, any
Proxy:HTTP request header is automatically mapped to theHTTP_PROXYenvironment variable by the CGI specification. A malicious client can send a craftedProxy:header to redirect outbound HTTP requests made by PHP (via Guzzle, cURL, orfile_get_contents) through an attacker-controlled proxy.This affects any PHP code that respects the
HTTP_PROXYenvironment variable, including:file_get_contentsHTTP_PROXYfor proxy configurationThe Varnish VCL templates already mitigate this (see #40654), but the Nginx sample config does not.
Solution
Add
fastcgi_param HTTP_PROXY "";to all three FastCGI pass blocks innginx.conf.sample:/setup)/update)This ensures the
HTTP_PROXYenvironment variable is always empty regardless of client-supplied headers.References
Files Changed
nginx.conf.sample⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz