fix(pagecache): preserve stale cache object when bgfetch returns 5xx#40675
Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Open
fix(pagecache): preserve stale cache object when bgfetch returns 5xx#40675lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
Conversation
|
Hi @lbajsarowicz. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
return (abandon)when a background fetch receives a 5xx response, preventing a failing backend refresh from replacing a usable stale cache object.Problem
Magento's VCL templates use grace periods to serve stale content while revalidating in the background. However, if the backend returns a 5xx error during this background fetch, Varnish replaces the cached object with the error response. This defeats the purpose of grace-based serving during backend incidents.
Solution
Add an early check in
vcl_backend_response:This follows Varnish's documented grace behavior and ensures stale objects survive backend failures during revalidation.
Applied to varnish5, varnish6, and varnish7 templates (
bereq.is_bgfetchrequires Varnish 5.1+).Files Changed
app/code/Magento/PageCache/etc/varnish5.vclapp/code/Magento/PageCache/etc/varnish6.vclapp/code/Magento/PageCache/etc/varnish7.vclRef #40673
⭐ Support my work
Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.
Learn more at https://github.com/sponsors/lbajsarowicz