Fix MDFC mana value#15471
Open
nandmp wants to merge 2 commits into
Open
Conversation
JayDi85
requested changes
Jun 30, 2026
| if (secondSideCard != null && getCard() instanceof DoubleFacedCardHalf) { | ||
| DoubleFacedCardHalf half = (DoubleFacedCardHalf) getCard(); | ||
| if (half.getParentCard() instanceof ModalDoubleFacedCard) { | ||
| return secondSideCard.getManaValue(); |
Member
There was a problem hiding this comment.
Looks wrong. On battlefield and stack it must be current side. On other zones it must be left side. You are added left side on battlefield useless MDFC lookup. It's strange. Need more review-research from other devs.
P.S. Also don't forget to implement related use case in tests. It's important for such bugs. Maybe real bug in wrong targeting, not in mana value calculation.
Member
There was a problem hiding this comment.
this.card already contain actual card half ref (for transformed it will contain second side), so that parent card check looks useless
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15415