[don't merge] Fix show ward on disguised and cloaked cards#15470
Open
nandmp wants to merge 1 commit into
Open
Conversation
Contributor
|
Could you show a screenshot of this working? Could you test with cloaking a card that intrinsically has ward ability? Don't want to leak info in that scenario |
Contributor
Author
It would be nice if it were to show the original face down card like it does on arena as well. |
JayDi85
changed the title
JayDi85
requested changes
Jul 1, 2026
| Ability newAbility = blueprintAbility.copy(); | ||
| newAbility.setRuleVisible(CardUtil.isInformationAbility(newAbility)); | ||
| newAbility.setRuleVisible(CardUtil.isInformationAbility(newAbility) || (newAbility instanceof WardAbility && | ||
| (faceDownType == FaceDownType.DISGUISED || faceDownType == FaceDownType.CLOAKED))); |
Member
There was a problem hiding this comment.
Thats wrong place.
There is other place to text hint inject (see constructor).
There is related issue to hide some face down info (#13431).
There is special unit test for it: test_NormalPlay_ClientData_CostRulesVisible
I'll try to research and fix it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15190