Repository navigation
fix(cloud): default to automatic underlying cloud selection - #278
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
launch_cloud()currently forces Modal workers onto AWS by default and rejectscloud=None. Default toNoneacross single pipelines, pipeline sequences, the launcher, and serialized runtime requests so the execution backend can choose the underlying cloud.Explicit
aws,gcp, andocivalues remain supported; invalid values are rejected. Region defaults and filtering are unchanged. Customer docs explain how cloud selection differs from the execution backend.Validation
Rollout dependency
Deploy https://github.com/macrodata-labs/perpetuity/pull/963 before releasing this change. Older controllers silently replace null/missing cloud with AWS. Existing jobs that explicitly request AWS are unaffected. No live cloud job was modified during this work.