Skip to content

fix(cloud): default to automatic underlying cloud selection - #278

Merged
Guilherme Penedo (guipenedo) merged 2 commits into
mainfrom
codex/optional-modal-cloud
Sep 15, 2026
Merged

Guilherme Penedo (guipenedo) merged 2 commits into
mainfrom
codex/optional-modal-cloud

Conversation

@guipenedo

@guipenedo Guilherme Penedo (guipenedo) commented Sep 15, 2026 •

Copy link
Copy Markdown
Collaborator

Change

launch_cloud() currently forces Modal workers onto AWS by default and rejects cloud=None. Default to None across single pipelines, pipeline sequences, the launcher, and serialized runtime requests so the execution backend can choose the underlying cloud.

Explicit aws, gcp, and oci values remain supported; invalid values are rejected. Region defaults and filtering are unchanged. Customer docs explain how cloud selection differs from the execution backend.

Validation

  • Focused launcher tests: 88 passed; platform client tests also passed.
  • Repository-wide Ruff lint, formatter check, and type check pass; pre-commit hooks pass.
  • Full SDK test suite: 1,386 passed, 25 skipped (existing TensorFlow isolation and GPU-only skips).
  • Tests cover default null serialization, explicit None, explicit cloud choices, multi-stage propagation, and invalid values.

Rollout dependency

Deploy https://github.com/macrodata-labs/perpetuity/pull/963 before releasing this change. Older controllers silently replace null/missing cloud with AWS. Existing jobs that explicitly request AWS are unaffected. No live cloud job was modified during this work.

Co-Authored-By: Codex <noreply@openai.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-15T14:59:34.037866Z d507ce6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Co-Authored-By: Codex <noreply@openai.com>
@guipenedo
Guilherme Penedo (guipenedo) merged commit 30c69ca into main Sep 15, 2026
5 checks passed
@guipenedo
Guilherme Penedo (guipenedo) deleted the codex/optional-modal-cloud branch September 15, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant