Fix AtomS3R LCD padding for mipi_spi - #98
Open
gwaland wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit
pad_widthandpad_heightvalues to the AtomS3Ratoms3r_lcdmipi_spidisplay definitions.ESPHome 2026.6.x changed
mipi_spipadding/rotation behavior. Without explicit padding, AtomS3R ST7789V displays usingrotation: 180°can show corrupted/pixelated output even though the device otherwise boots and functions normally.Tested
pad_width: 2andpad_height: 1fixes the display while preservingrotation: 180Fixes #96