Skip to content

Panel_IT8951: Deassert CS on BUSY timeout in _write_args - #247

Merged
lovyan03 merged 2 commits into
developfrom
copilot/fix-code-for-review-comments
Aug 13, 2026
Merged

Panel_IT8951: Deassert CS on BUSY timeout in _write_args#247
lovyan03 merged 2 commits into
developfrom
copilot/fix-code-for-review-comments

Conversation

Copilot AI commented Aug 13, 2026

Copy link
Copy Markdown

During a multi-word burst in _write_args, a BUSY timeout was returning false without deasserting CS, leaving the panel selected until some outer cleanup path (e.g. endTransaction) ran—which isn't guaranteed on all error paths and can corrupt shared-bus communication.

Change

  • Panel_IT8951::_write_args: Call cs_control(true) before returning false on _wait_busy_pin() timeout, ensuring CS is deasserted on every exit path.
if (!_wait_busy_pin())
{
  cs_control(true);  // deassert CS before bailing out
  return false;
}

Co-authored-by: lovyan03 <42724151+lovyan03@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code based on review comments from pull request 246 Panel_IT8951: Deassert CS on BUSY timeout in _write_args Aug 13, 2026
Copilot AI requested a review from lovyan03 August 13, 2026 01:12
@lovyan03
lovyan03 marked this pull request as ready for review August 13, 2026 01:13
@lovyan03
lovyan03 merged commit 989467f into develop Aug 13, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants