feat: 98% safety rate multiplier in Earner rate model#195
Merged
toninorair merged 6 commits intomainfrom Jun 4, 2025
Merged
Conversation
PierrickGT
approved these changes
Nov 6, 2024
| uint256 safeEarnerRate_ = getSafeEarnerRate(totalActiveOwedM_, totalEarningSupply_, minterRate_); | ||
| uint256 extraSafeEarnerRate_ = (safeEarnerRate_ * RATE_MULTIPLIER) / ONE; | ||
|
|
||
| return (extraSafeEarnerRate_ > type(uint32).max) ? type(uint32).max : uint32(extraSafeEarnerRate_); |
Member
There was a problem hiding this comment.
We could use bound32() from UIntMath:
Suggested change
| return (extraSafeEarnerRate_ > type(uint32).max) ? type(uint32).max : uint32(extraSafeEarnerRate_); | |
| return UIntMath.bound32(extraSafeEarnerRate_); |
LCOV of commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the actual switch from 90% to 98% multiplier, a public getter function
getExtraSafeEarnerRatewas introduced.It will be used by M0 colleagues to predict/query an expected rate based on
totalEarningSupply,totalActiveOwedM,minterRatewithout knowing extra details about the rate multiplier.