Repository navigation
feat: 支持独立配置桌面歌词的翻译、罗马音和逐字歌词 - #2976
Open
lingwateryang wants to merge 2 commits into
Open
lingwateryang wants to merge 2 commits into
lingwateryang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
桌面歌词目前共用播放页的翻译、罗马音、显示顺序和逐字歌词设置,无法同时使用“播放页显示扩展歌词、桌面只显示原文”等组合。
修改内容
desktopLyric.*设置,覆盖翻译、罗马音、两者顺序交换和逐字歌词。验证
npm ci --ignore-scripts --no-audit --no-fundnpm run lint:通过。npm run build:主进程、主窗口、桌面歌词及脚本均构建成功。git diff --check:通过。手动复核步骤
本 PR 只提交通用源码,不包含个人配置、日志、截图、安装包、本机路径或凭据。
追加修复:资源管理器重启后恢复隐藏状态
复现
实现
type: 'toolbar'创建歌词窗口,让窗口具备工具窗口属性,而不只依赖当前任务栏的setSkipTaskbar状态。setSkipTaskbar行为。closed回调只清理它所属的窗口引用,避免旧窗口延迟关闭时清空新窗口引用。验证
npm run lint和npm run build均通过。追加提交仍只包含通用源码,不上传本机补丁脚本、配置、截图、路径或凭据。