Skip to content

feat: email theme#55

Closed
paulwer wants to merge 85 commits into
lukin:masterfrom
paulwer:patch-3
Closed

feat: email theme#55
paulwer wants to merge 85 commits into
lukin:masterfrom
paulwer:patch-3

Conversation

@paulwer

@paulwer paulwer commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

closes #47
references #6

Hey folks, ive managed a mailwind integration.

From my pov it may not be perfect, but it works as intended (for me).
any thoughts on this?

I've created this theme based on the mailwind front-website example.

emails should be tested for visibility on the most used e-mail clients (help wanted):

  • Apple
  • GMAIL
  • Outlook
  • Thunderbird
  • Yahoo Mail
  • WEB.de
  • Outlook.com

@ghost

ghost commented Sep 28, 2023

Copy link
Copy Markdown

Feel free to send emails to folkers [at] codefy [dot] de and I'll post screenshots 😉

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

@CHE1RON you should have recieved an email yesterday :)

@ghost

ghost commented Sep 29, 2023

Copy link
Copy Markdown
Screenshot 2023-09-29 at 10 03 23

looks good 👍

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

yahoo
Unbenannt

known issues:

  • no background at all => I guess we can ignore this

@paulwer

This comment was marked as resolved.

@ghost

ghost commented Sep 29, 2023

Copy link
Copy Markdown

@paulwer I mean it says right there in your screenshot: if it looks shitty, please view it in your browser 😂

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

@CHE1RON I've sended you another e-mail, please check the formatting, outlook looks now better and the other platforms are still optical the same:
Unbenannt

i changed the usage of div's to the table syntax for old email clients.
i will commit, if this looks also good on apple :)

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

outlook.com works like a charm
Unbenannt

background images are now present on all platforms i tested. <3 (only outlook destop does not display it xD)

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

thunderbird also works great <3
Unbenannt

android gmail and outlook tested as well and worked great. gmail does display it as dark mode variant, but its readable and approved from my pov.

@paulwer

paulwer commented Sep 29, 2023

Copy link
Copy Markdown
Contributor Author

@lukin any test files needed for this PR?

@ghost

ghost commented Sep 30, 2023

Copy link
Copy Markdown

macOS Mail:

image

@paulwer

This comment was marked as outdated.

@paulwer

paulwer commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

within this PR, I used the mailwind logo as default logo.
should we replace it with a keycloak logo to match a more "default" - alike look or remove the logo by default, to be fit with plain installation and maybe display just the realm name, if nothing is defined...
I could also imagine a customization behavior within theme.properties, like mentioned in: #59

any opinions on that? @lukin @CHE1RON

@ghost

ghost commented Oct 2, 2023

Copy link
Copy Markdown

I see no apparent reason why keywind should propagate Mailwind by using its logo by default 🤔

No logo imho 👍

@paulwer

paulwer commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

@CHE1RON is right, the logo should be optional. Therefore i will push a commit with the mentioned themeLogoUrl as property of the theme shortly. if no url is provided the realmName as heading is used accordingly.

@lukin PR is ready again :)

@paulwer

paulwer commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

closed in favor for:
#96

@paulwer paulwer closed this Jun 19, 2024
@LeftoversTodayAppAdmin

Copy link
Copy Markdown

Hey folks,
How do I get the email template? The latest keywind branch still doesnt show any email templates at all?

@paulwer

paulwer commented Aug 22, 2024

Copy link
Copy Markdown
Contributor Author

this was closed in favor for #96.
all changes here are present in the other pr

@paulwer paulwer mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E-Mail Theme