Update to v1.0.3 SDWebImage Version - #11
Conversation
…arinComponents repository - Use libwebp from SDWebImage - Update libwebp version to v1.0.3 - Use carthage for compiling libwebp depedency - Use libwebp framework instead of A file - Copy dependent frameworks to frameworks for future references - Update Nuget package to v1.0.7.3
| // and "{Major}.{Minor}.{Build}.*" will update just the revision. | ||
|
|
||
| [assembly: AssemblyVersion("1.0.*")] | ||
| [assembly: AssemblyVersion("1.0.3")] |
There was a problem hiding this comment.
is there a reason to have the Build specified?
There was a problem hiding this comment.
I want the assembly to have the same version as the main library.
Any subsequence changes will be increase 1 by 1.
E.g. if native library version is 1.0.3 then our first binding version will be 1.0.3.
If there are any corrections afterward, we will increase version by the forth part -> 1.0.3.x.
That way we will know what is the actual version of the native library easily.
You might check out the way Xamarin support libraries versioned.
|
|
||
| namespace WebP | ||
| { | ||
| internal static class CFunctions |
There was a problem hiding this comment.
if not used you can drop it
There was a problem hiding this comment.
:). I copied from the iOS proj.
| [assembly: AssemblyTitle("WebP.tvOS")] | ||
| [assembly: AssemblyDescription("")] | ||
| [assembly: AssemblyConfiguration("")] | ||
| [assembly: AssemblyCompany("NAXAM COMPANY LIMITED")] |
There was a problem hiding this comment.
@daniel-luberda should we keep these assembly company/trademark etc ?
| { | ||
| private readonly WebPDecoder _decoder; | ||
|
|
||
| /// <summary> |
There was a problem hiding this comment.
formatting looks strange, maybe you can autoformat?
There was a problem hiding this comment.
Weird, code is copied from iOS source.
|
@tuyen-vuduc Fantastic work! Thanks a lot. |
- remove trademark and company info
|
Hi @molinch, I made the changes to
Please check it again. |
|
@tuyen-vuduc Looks perfect to me, unfortunately I cannot test it yet. |
|
Hi guys, Do you all review it? I really expect it to be released ASAP 💯 Thanks. |
|
@molinch, @Benesss, @daniel-luberda, Could we do the merge and publish new package? If you don't have time to maintain the binding, could you invite me as a maintainer and the package distributor? Thanks. |
|
Hi @tuyen-vuduc Could you tell me what's the size of the lib after compilation? I'm worried that it would be twice as current one, because we use decoder only ( |
|
Hi @daniel-luberda, The framework compiled with Carthage is 6.7MB while the previous one is ~4.5MB. I think SDWebImage is very commonly used by native iOS developers. I won't think it'll be issue. Additionally, by using that the same lib from SDWebImage, we could use this library as the dependency for SDWebImage package; otherwise it isn't possible. Other than that, the reason I compiled the new A lib because when I linked this current WebP.Touch nuget package with SDWebImage nuget package in Xamarin component, it doesn't work. Regards. |
|
@daniel-luberda How do you think? |
|
Hi guys, Really wanted to get this merge. Thank you. |
|
Hi guys, Any progress here? |
3 participants
Try the package before merge from here