Fix banner image rendering on mobile - #259
Merged
Merged
Conversation
Without object-fit, an <img> constrained by both width: 100% and max-height: 300px is stretched vertically once its natural height at container width exceeds 300px. Crop it instead, matching the previous background-size: cover behaviour.
lowercasename
force-pushed
the
mobile-banner
branch
from
August 15, 2026 17:35
c209102 to
2a40541
Compare
Owner
|
Just added a small fix to avoid stretched images on desktop - thank you, this is a great fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if an event host uploads a banner image, it appears cut off on mobile.
Closes #171
Here's what that looks like today:
With this PR, it is now fit to the viewport width:
Banner images still render the same on desktop: