-
Notifications
You must be signed in to change notification settings - Fork 13
[top,sw/dv] Clk pwr rst smoke tests #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
csabakiss-semify
wants to merge
4
commits into
lowRISC:main
Choose a base branch
from
csabakiss-semify:clk_pwr_rst_smoke_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5f5191d
[sw] Added reset manager smoke test
csabakiss-semify 0345940
[sw] Added clock manager smoke test
csabakiss-semify 7adf270
[sw] Added power manager smoke test
csabakiss-semify 20e0f44
[script] Added reset manager, clock manager and power manager smoke t…
csabakiss-semify File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,15 +10,21 @@ | |
| bool test_main() | ||
| { | ||
| rstmgr_t rstmgr = mocha_system_rstmgr(); | ||
| uint32_t reason = rstmgr_reset_reason_get(rstmgr); | ||
|
|
||
| if (rstmgr_software_reset_info_get(rstmgr)) { | ||
| return true; | ||
| if (reason & RSTMGR_RESET_INFO_POR) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice, this is a good change! |
||
| rstmgr_reset_reason_clear(rstmgr, RSTMGR_RESET_INFO_POR); | ||
| rstmgr_software_reset_request(rstmgr); | ||
|
|
||
| // Must wait here for reset to happen. | ||
| while (1) { | ||
| } | ||
| } | ||
| // Request a reset of the system. | ||
| rstmgr_software_reset_request(rstmgr); | ||
|
|
||
| // Must wait here for reset to happen. | ||
| while (1) { | ||
| if (reason & RSTMGR_RESET_INFO_SW_RESET) { | ||
| rstmgr_reset_reason_clear(rstmgr, RSTMGR_RESET_INFO_SW_RESET); | ||
| return true; | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can now remove this function. I think it was only used in the software_reset test.