Skip to content

Fix connection secure port management.#162

Open
stankudrow wants to merge 15 commits into
long2ice:devfrom
stankudrow:fix-connection-default-secure-port
Open

Fix connection secure port management.#162
stankudrow wants to merge 15 commits into
long2ice:devfrom
stankudrow:fix-connection-default-secure-port

Conversation

@stankudrow

@stankudrow stankudrow commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Fix errors in the connection security parameter + minor (un)related corrections

This PR was inspired by #138, and I thought it would be a good idea to split the secure connection case and query parametrisation, focusing only on the first part. It wasn't straightforward, but perhaps that's for the best.

@barakor, I hope I'm not stepping on your toes — I fully acknowledge your contribution. I'd appreciate it if you could also review this PR; your suggestions will be greatly appreciated and carefully addressed.

Some tests used to fail due to issues with parameter substitution processing (related to #147). @baconfield, @dmkulazhenko, could you please review these changes?

I experimented with configuring connections in the tests, which caused tests using a bare Connection() or Pool(...) without connection_kwargs to fail. This is actually a positive outcome, as it revealed the fragility of those tests.

@long2ice, @nils-borrmann-tacto, @DaniilAnichin, I had some difficulty specifying the pytest-asyncio asyncio_default_fixture_loop_scope attribute and addressing the warning from pytest: neither the "session" nor the "function" scope resolves the issue. By the way, your reviews would be very welcome.

Comment thread asynch/proto/connection.py
Comment thread asynch/connection.py Outdated
Comment thread asynch/connection.py
@stankudrow

Copy link
Copy Markdown
Contributor Author

@baconfield . @nils-borrmann-tacto , @long2ice , damn, this PR should go first because the failed CI in the dev - https://github.com/long2ice/asynch/actions/runs/27552079391/job/81440866403 . @barakor, @dmkulazhenko , @DaniilAnichin , @pohmelie, please help with reviews.

Comment thread asynch/connection.py Outdated
@DaniilAnichin

Copy link
Copy Markdown
Contributor

Seems to be ok; about the pytest-asyncio: mostly I've dealt with it by switching to anyio, but I don't think this is a PR to do it in.

@stankudrow

Copy link
Copy Markdown
Contributor Author

Seems to be ok; about the pytest-asyncio: mostly I've dealt with it by switching to anyio, but I don't think this is a PR to do it in.

Yeah, you are right, this PR is not about anyio. However, before proposing a PR, feel free to open an issue and lay out pros and cons of anyio, examples etc.

@stankudrow stankudrow requested a review from pohmelie June 17, 2026 20:59
Comment thread tests/test_proto/utils/test_escape.py

@barakor barakor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok overall, but the change in asynch/connection.py that I commented about is problematic

Comment thread asynch/proto/connection.py
Comment thread asynch/proto/connection.py Outdated
Comment thread asynch/connection.py Outdated
Comment thread asynch/connection.py Outdated
Comment thread tests/test_proto/utils/test_escape.py
stankudrow and others added 2 commits June 18, 2026 02:37
Co-authored-by: Barak <26878518+barakor@users.noreply.github.com>
Co-authored-by: Barak <26878518+barakor@users.noreply.github.com>
@baconfield

baconfield commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@baconfield . @nils-borrmann-tacto , @long2ice , damn, this PR should go first because the failed CI in the dev - https://github.com/long2ice/asynch/actions/runs/27552079391/job/81440866403 . @barakor, @dmkulazhenko , @DaniilAnichin , @pohmelie, please help with reviews.

Resolved with #163

@stankudrow stankudrow requested a review from barakor June 18, 2026 04:58
@stankudrow

stankudrow commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

@baconfield . @nils-borrmann-tacto , @long2ice , damn, this PR should go first because the failed CI in the dev - https://github.com/long2ice/asynch/actions/runs/27552079391/job/81440866403 . @barakor, @dmkulazhenko , @DaniilAnichin , @pohmelie, please help with reviews.

Resolved with #163

The changes from the #163 were here before - https://github.com/long2ice/asynch/pull/162/changes#diff-94026d54d9ecff66c0362322fe026b6995eb0bdbb56bb8bf84447fc7fa148b04 . You can close the #163 PR.

@stankudrow stankudrow requested a review from DaniilAnichin June 18, 2026 20:03
@stankudrow stankudrow requested a review from pohmelie June 18, 2026 20:03
@stankudrow

Copy link
Copy Markdown
Contributor Author

@DaniilAnichin , @pohmelie , hello.

In spite of these changes, could you re-review and re-approve them in case they are really OK? After that this PR can go to the final-boss review. Sorry for these bureaucratic troubles.

@stankudrow

Copy link
Copy Markdown
Contributor Author

@long2ice , hello.

This PR seems to be "mergeable".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants