Skip to content

Fix compression for inserts #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nils-borrmann-tacto wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix compression for inserts #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions asynch/proto/streams/buffered.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ def __init__(
async def flush(self):
await self.compressor.write(self.buffer)
self.position = 0
self.buffer = bytearray()


class CompressedBufferedReader(BufferedReader):
Expand Down
16 changes: 14 additions & 2 deletions tests/test_proto/test_proto_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@
from asynch.proto.cs import ServerInfo


@pytest.fixture()
async def proto_conn(config) -> AsyncIterator[ProtoConnection]:
@pytest.fixture(params=[False, "lz4", "zstd"])
async def proto_conn(request, config) -> AsyncIterator[ProtoConnection]:
_conn = ProtoConnection(
user=config.user,
password=config.password,
host=config.host,
port=config.port,
database=config.database,
compression=request.param,
)
await _conn.connect()
yield _conn
Expand Down Expand Up @@ -103,6 +104,17 @@ async def test_execute_with_missing_arg(proto_conn: ProtoConnection):
await proto_conn.execute(query, args={"foo": 1})


@pytest.mark.asyncio
async def test_large_insert(proto_conn: ProtoConnection):
data = [(1,)] * 10_000
async with create_table(proto_conn, "a Int64"):
await proto_conn.execute(
"INSERT INTO test.test (a) VALUES", data, settings={"insert_block_size": 1000}
)
rv = await proto_conn.execute("SELECT * FROM test.test")
assert rv == data


@asynccontextmanager
async def create_table(connection, spec):
await connection.execute("DROP TABLE IF EXISTS test.test")
Expand Down