Skip to content

Gracefully recover from OperationalError in ping (#6) #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nils-borrmann-tacto wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Gracefully recover from OperationalError in ping (#6) #148

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e227f
Recover from OperationalError in ping (#6)
nils-borrmann-tacto Nov 19, 2025
2ecc8b0
lint
nils-borrmann-tacto Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions asynch/proto/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from urllib.parse import urlparse

from asynch.errors import (
OperationalError,
PartiallyConsumedQueryError,
ServerException,
UnexpectedPacketFromServerError,
Expand Down Expand Up @@ -320,10 +321,12 @@ async def ping(self) -> bool:
msg = self.unexpected_packet_message("Pong", packet_type)
raise UnexpectedPacketFromServerError(msg)
return True
except AttributeError:
logger.debug("The connection %s is not open", self)
except OperationalError as e:
logger.info("The connection %s is not open", self, exc_info=e)
except AttributeError as e:
logger.info("The connection %s is not open", self, exc_info=e)
except IndexError as e:
logger.debug(
logger.info(
"Ping package smaller than expected or empty. "
"There may be connection or network problems - "
"we believe that the connection is incorrect.",
Expand All @@ -334,7 +337,7 @@ async def ping(self) -> bool:
# because this is a connection loss case
if isinstance(e, RuntimeError) and "TCPTransport closed=True" not in str(e):
raise e
logger.debug("Socket closed", exc_info=e)
logger.info("Socket closed", exc_info=e)
return False

async def receive_data(self, raw=False):
Expand Down