release(core): support user lookup by external identity - #9598
Open
wangsijie wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The public OpenAPI contract allows empty provider and identity values that the route always rejects.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Releases external-identity user lookup through the Management API.
Changes:
- Removes the development-feature guard.
- Publishes OpenAPI parameters and adds release notes.
- Updates route and Swagger tests.
File summaries
| File | Description |
|---|---|
.changeset/external-identity-user-lookup.md |
Documents the public feature. |
packages/core/src/routes/admin-user/search.ts |
Removes the runtime feature guard. |
packages/core/src/routes/admin-user/search.test.ts |
Removes obsolete guarded-state tests. |
packages/core/src/routes/admin-user/search.openapi.json |
Publishes identity query parameters. |
packages/core/src/routes/swagger/utils/general.test.ts |
Verifies parameters remain public. |
Review details
Suppressed comments (1)
packages/core/src/routes/admin-user/search.openapi.json:28
- The route also rejects an empty
identityId, while the public schema accepts it. Mark this string as non-empty so API consumers receive the same constraint as the server enforces.
"type": "string"
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release user lookup by external identity in the Management API
GET /api/usersendpoint.The endpoint now accepts
identityType,identityProvider, andidentityIdquery parameters for exact user lookup. UseidentityType=socialwith a connector target (such asdingtalk), oridentityType=ssowith an enterprise SSO issuer, together with the user identifier issued by the external provider. The identity filter is combined with other search filters using AND logic.Testing
Unit tests
Tested locally