fix(core): fall back to base language for API error messages - #9597
Merged
Merged
Conversation
charIeszhao
requested review from
gao-sun,
simeng-li and
wangsijie
as code owners
September 14, 2026 03:19
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation reuses established language matching behavior and is comprehensively tested.
Pull request overview
Fixes API error localization by matching regional language tags to supported base languages.
Changes:
- Uses the shared language matcher with built-in API locales.
- Adds regional fallback, preference-order, and request-isolation tests.
- Adds a patch changeset.
File summaries
| File | Description |
|---|---|
packages/core/src/middleware/koa-i18next.ts |
Resolves supported regional/base languages. |
packages/core/src/middleware/koa-i18next.test.ts |
Expands localization middleware coverage. |
.changeset/lucky-spoons-itch.md |
Documents the user-facing bug fix. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
simeng-li
approved these changes
Sep 14, 2026
gao-sun
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix API error messages falling back to English when a regional language tag such as
es-MXorfr-CAhas a supported base language. Reuse the shared language matcher so API errors resolve toesorfr, respecting request language preferences and keeping translation instances scoped to each request.Fixes #9594.
Testing
Unit tests
Checklist
.changeset