fix(cli): check for existing tenant roles before seeding - #9573
Open
ryanchou1994 wants to merge 2 commits into
Open
fix(cli): check for existing tenant roles before seeding#9573ryanchou1994 wants to merge 2 commits into
ryanchou1994 wants to merge 2 commits into
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/quiet-roles-seed.md | 📈 +414 Bytes |
| packages/cli/src/commands/database/seed/index.ts | 📈 +331 Bytes |
| packages/cli/src/queries/database.test.ts | 📈 +2.45 KB |
| packages/cli/src/queries/database.ts | 📈 +1.75 KB |
wangsijie
reviewed
Sep 10, 2026
Author
|
Thanks, both make sense. I'll derive the role names from |
…e transaction - derive the role names from `createTenantDatabaseMetadata()` so the check keeps matching if the naming scheme ever changes - run the check at the top of `seedByPool()` before opening the transaction; `createTables()` goes back to its original shape
wangsijie
approved these changes
Sep 11, 2026
charIeszhao
approved these changes
Sep 14, 2026
gao-sun
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dropping a Logto database leaves its PostgreSQL roles in the cluster. Seeding a new database with the same name then fails with a role-already-exists error.
Check the three tenant roles needed by the seed before creating any tables. If any already exist, report their names and explain why they survived the database deletion so an administrator can inspect them before retrying. Existing roles and permissions are left unchanged.
Fixes #9555.
Testing
Checklist
.changeset