chore(deps): update dependency browserslist to v4.28.7 [security] - #9544
renovate[bot] wants to merge 1 commit into
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| pnpm-lock.yaml | 📉 -389 Bytes |
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile shows an inconsistent/invalid peer resolution where @withtyped/server (peer zod: ^3.19.1) is resolved with zod@4.4.3, indicating the lockfile likely needs regeneration or constraint adjustments before it’s safe to merge.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s resolved npm dependency graph (via pnpm-lock.yaml) to address a Browserslist security advisory and refresh related transitive packages.
Changes:
- Updated the resolved
browserslistversion used bypackages/experienceto4.28.7. - Refreshed multiple transitive dependencies pulled in by the new resolution (e.g.
caniuse-lite,electron-to-chromium,node-releases,update-browserslist-db, etc.). - Introduced additional resolution changes including
browserslist@4.28.8andzod@4.4.3appearing in parts of the lockfile.
File summaries
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates the lockfile to resolve browserslist to 4.28.7 and refreshes associated transitive dependencies. |
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-lock.yaml:5074
- This importer lists
zodwithspecifier: 3.24.3but resolves it toversion: 4.4.3, which is inconsistent with the requested range and suggests the lockfile is out of sync with the workspace manifests/peer resolution.
Regenerate the lockfile so the resolved Zod version satisfies the specifier (likely 3.24.3 here).
- Files reviewed: 0/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| '@withtyped/server': | ||
| specifier: ^0.14.0 | ||
| version: 0.14.0(zod@3.24.3) | ||
| version: 0.14.0(zod@4.4.3) |
| browserslist@4.28.8: | ||
| resolution: {integrity: sha512-V2NpofLblG64mfOtSgDhOJESZEGogzDMBv/q+W6oc4LXWP/q75eOXoOaaOu1EOadB9U4Bwx/e0yzbvwKH8zalA==} |
6be3a37 to
77590ae
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile resolves packages/schemas’ zod peer to an incompatible version and contains additional dependency changes beyond the stated browserslist-only scope.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-lock.yaml:5068
- In
packages/schemas, the lockfile resolves thezodpeer to 4.4.3 even though the peer specifier is exactly3.24.3, and it also picks the@withtyped/serverpeer variant forzod@4.4.3. This creates an unmet peer dependency and can lead to inconsistent type/runtime behavior; the lockfile should resolve this peer to 3.24.3 (or the peer range should be widened in package.json in a separate change).
- Files reviewed: 0/1 changed files
- Comments generated: 1
- Review effort level: Lite
| browserslist: | ||
| specifier: ^4.23.2 | ||
| version: 4.23.2 | ||
| version: 4.28.7 | ||
| browserslist-to-esbuild: | ||
| specifier: ^2.1.1 | ||
| version: 2.1.1(browserslist@4.23.2) | ||
| version: 2.1.1(browserslist@4.28.7) |
77590ae to
1fa5bfb
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The lockfile currently resolves packages/schemas to an invalid peer combination (@withtyped/server with zod@4.4.3 despite zod: ^3.19.1), which can break installs (especially with --frozen-lockfile).
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (3)
pnpm-lock.yaml:5068
- In
packages/schemas,@withtyped/serveris locked as0.14.0(zod@4.4.3), but@withtyped/server@0.14.0declares a peer dependency ofzod: ^3.19.1(see lock entry), so this peer resolution is invalid and will likely produce install warnings/errors.
pnpm-lock.yaml:5074 - In
packages/schemas, the lockfile recordszodwith specifier3.24.3but resolves it to4.4.3, which does not match the workspacepackage.jsondependencies and can breakpnpm install --frozen-lockfile(and also conflicts with@withtyped/server'szod: ^3.19.1peer).
pnpm-lock.yaml:20911 - The lockfile contains a snapshots entry for
@withtyped/server@0.14.0(zod@4.4.3), but@withtyped/server@0.14.0peerszod: ^3.19.1. This snapshot should be removed so the graph only uses thezod@3.24.3variant.
- Files reviewed: 0/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
1fa5bfb to
07adf7b
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The lockfile now resolves @logto/schemas’ zod peer to 4.4.3 despite a 3.24.3 specifier/peer constraint, which is likely unintended and can cause peer mismatch or build/test issues.
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-lock.yaml:5074
- In packages/schemas importer, the lockfile records zod with specifier 3.24.3 but resolves it to 4.4.3. This does not satisfy @logto/schemas' declared peerDependency on zod (packages/schemas/package.json:91-93) and likely indicates an unintended peer-resolution conflict (or lockfile drift) introduced alongside the browserslist update; please regenerate the lockfile after resolving the intended zod version/peer range (e.g., keep zod at 3.24.3 here, or widen the peer range if zod v4 is intended and compatible).
- Files reviewed: 0/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
07adf7b to
01d1dcf
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
The lockfile has an unresolved Zod peer-version mismatch.
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-lock.yaml:5068
- This importer belongs to
packages/schemas, whose peer dependency is exactlyzod: 3.24.3(packages/schemas/package.json:91-93), but the lockfile now selects the zod 4 peer context for@withtyped/serverand selectszod@4.4.3below. That leaves the lockfile inconsistent with the unchanged manifest and can install an unmet major-version peer (or fail peer validation); keep this importer wired to the existing zod 3.24.3 snapshot.
- Files reviewed: 0/1 changed files
- Comments generated: 0 new
- Review effort level: Lite
01d1dcf to
160f6bc
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile update appears to unintentionally introduce a major Zod version change/mismatch (v3 → v4) in packages/schemas, which is out of scope for a Browserslist-only security bump and could be breaking.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (2)
pnpm-lock.yaml:5068
- The lockfile updates
@withtyped/serverinpackages/schemasto resolve againstzod@4.4.3, which is a major Zod upgrade and appears unrelated to the stated Browserslist security bump. This broadens the PR scope and risks breaking runtime/type compatibility; consider pinning/overriding to keep Zod v3 here, or explicitly upgrading Zod in the manifests as a separate, intentional change and regenerating the lockfile.
pnpm-lock.yaml:20912 - The lockfile now contains both
@withtyped/server@0.14.0(zod@3.24.3)and@withtyped/server@0.14.0(zod@4.4.3), implying mixed Zod major versions in the dependency graph. This can lead to duplicated Zod installs and incompatible schema/type instances; it would be safer to keep a single Zod major version across the workspace and regenerate the lockfile.
- Files reviewed: 0/1 changed files
- Comments generated: 1
- Review effort level: Lite
| zod: | ||
| specifier: 3.24.3 | ||
| version: 3.24.3 | ||
| version: 4.4.3 |
This PR contains the following updates:
4.23.2→4.28.7Browserslist: Uncaught crash / prototype write via untrusted browserslist-stats.json custom stats (normalizeStats)
CVE-2026-73088 / GHSA-73wf-gq98-2v4g
More information
Details
Vulnerability Details
File:
node.jsFunction:
normalizeStats()(line ~214), reached fromgetStat()(calledunconditionally on every
browserslist()call) andloadStat()Root Cause
statsis untrusted: it comes fromJSON.parse()-ing abrowserslist-stats.jsonfile — auto-discovered by walking up the directorytree from the project root on every
browserslist()call, regardless ofthe query (
env.getStat(opts, browserslist.data)runs unconditionallyinside
browserslist()) — or fromopts.statspassed programmatically /via the CLI's
--stats=flag.dataisbrowserslist.data, a plain objectpopulated only with real browser names.
Two independent bugs from the same root cause (unguarded
for...inoveruntrusted keys used with plain-object bracket access/assignment):
data[i]has nohasOwnPropertyguard. Ifstatscontains akey that also happens to be an inherited
Object.prototypemember name —"__proto__","toString","valueOf","constructor","hasOwnProperty","isPrototypeOf", etc. —data[i]resolves to thatinherited function/object (always truthy), and the code then does
data[i].versions.length→undefined.length→ uncaughtTypeError,for any such key whose JSON value has exactly one sub-key, e.g.:
{ "toString": { "onekey": 5 }, "chrome": { "100": 50 } }normalized[i] = ...on the freshnormalized = {}— ifiis exactly"__proto__"(andnormalizedhasno own property by that name yet), this computed assignment invokes the
real
Object.prototype.__proto__setter, changingnormalized's actual[[Prototype]]instead of creating a plain property.Because this runs on every
browserslist()call regardless of thequery, simply committing a poisoned
browserslist-stats.jsonanywhere in aproject's directory tree breaks every subsequent Browserslist call in that
project — including calls made by Autoprefixer, Babel
preset-env,Stylelint, or PostCSS internally, for completely unrelated queries.
Attack Scenario
browserslist-stats.jsonfile anywhere between the project root andfilesystem root, containing e.g.
{"toString": {"onekey": 5}, "chrome": {"100": 50}}.browserslist()internally, for any query.
TypeErroron the very first call.Measured Impact
Confirmed crash (real
browserslist()call, v4.28.6) withstatskeys:__proto__,toString,valueOf,hasOwnProperty,constructor,isPrototypeOf— each paired with a one-key JSON object — for any query,including
browserslist('defaults')which never mentions stats.Recommended Fix (implemented and verified)
normalizedusesObject.create(null)so a write to"__proto__"is anordinary property set, never a
[[Prototype]]change;data[i]is replacedwith an explicit
hasOwnPropertycheck so it never resolves to an inheritedObject.prototypemember.Verification:
NODE_ENV=test npx uvu test .test.js→ 301/301 pass unmodified(
test/custom.test.js,test/shareable-stats.test.js,test/cover.test.jsexercise the stats-handling paths).
without error.
browserslist-stats.json+ an unrelatedbrowserslist('defaults')call)now returns a normal result instead of crashing.
Impact
(directly or via Autoprefixer/Babel/Stylelint/PostCSS) in a directory tree
an attacker can place a file into (external PR, compromised dependency),
or any app that passes user-influenced data into
opts.stats.process on the first Browserslist call after the file is present, for any
query, no special syntax needed.
file to the project's directory tree, or influence
opts.stats.Verification Environment
browserslist @ HEAD (== v4.28.6, current latest stable release) under local
Node.js v20.19.5. Pure JS library — executed directly, no server needed.
Note
Found via a systematic review of prototype-pollution-adjacent patterns in
this codebase after confirming two unrelated algorithmic-complexity issues
(reported separately as GHSA-rrmg-cfrq-23vv and GHSA-g6p8-hj8g-x889) in the
same research pass. A similar
for...in+ bracket-write pattern inindex.js'scopyObject()(used bynormalizeAndroidData) was alreadyguarded against
__proto__/constructor/prototypekeys by a prior,unrelated commit — that guard was never applied to this function.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Browserslist: Unbounded memory growth (no cache eviction) via distinct query results, leading to eventual OOM
CVE-2026-73089 / GHSA-c83g-rgw3-j3cx
More information
Details
Vulnerability Details
File:
index.jsLocation:
cache(browserslist()'s result cache, line ~402) andparseCache(parseQueries()'s AST cache)Root Cause
Every distinct
(queries, context)pair is cached forever — no size cap,TTL, or eviction.
browserslist.clearCaches()never resets either object(it only resets
node.js's own filesystem caches); the only opt-out is theBROWSERSLIST_DISABLE_CACHEenv var, controlled by the callingapplication, not an attacker.
Some short, valid queries amplify this badly. The
since <year>-<month>-<day>query type (
/^since (\d+)-(\d+)-(\d+)$/i) accepts any digitcombination —
Date.UTC()normalizes rather than rejects out-of-rangevalues — giving an effectively unbounded space of ~17-byte distinct cache
keys, each of which resolves to (and caches) a result close to the full
~8.5 KB browser list for any sufficiently old year.
Measured Impact
20,000 distinct
since <year>-<month>-<day>queries (~330 KB total input,--expose-gcbefore/after measurement to rule out uncollected garbage)retained over 50 MB of heap permanently — roughly 150x
amplification, growing linearly with no cap observed up to 40,000 queries
(52.3 MB).
Attack Scenario
Any long-running process (server, daemon, warm CI worker) that calls
browserslist()with a query value that varies across requests/items and isinfluenced, even partially, by external input accumulates one cache entry
per distinct value ever seen. An attacker who can influence that value
across many requests (this is a volumetric attack, unlike the
single-request DoS findings from this same research pass) sends a stream of
cheap, distinct queries (e.g.
since 1900-01-01,since 1900-01-02, ...)until the process runs out of memory and crashes.
Recommended Fix (implemented and verified)
Replace both plain-object caches with
Maps bounded to a fixed maximumentry count, evicting the oldest entry once the cap is reached (
Mappreserves insertion order, so
.keys().next().valueis always oldest):(read sites changed to
.has()/.get(), write sites toboundedCacheSet())Verification:
NODE_ENV=test npx uvu test .test.js→ 301/301 pass unmodified(
test/cache.test.jsexercisesclearCaches()/BROWSERSLIST_DISABLE_CACHEagainst
node.js's separate filesystem caches, unaffected here); confirmeda repeated identical call still returns the cached reference.
10,000, 20,000, and 40,000 distinct
since-date queries (was10.5 → 16.5 → 28.4 → 52.3 MB pre-fix).
Impact
browserslist()withquery values that vary across requests/items and are influenced by
external input.
sustained traffic over time (not a single small payload).
single request, hence Medium rather than High severity.
Verification Environment
browserslist @ HEAD (== v4.28.6, current latest stable release) under local
Node.js v20.19.5, run with
--expose-gcfor accurate heap measurement.Note
Found during a broader review of this codebase in the same research pass
that produced GHSA-rrmg-cfrq-23vv (parse.js algorithmic complexity),
GHSA-g6p8-hj8g-x889 (baseline regexp ReDoS), GHSA-73wf-gq98-2v4g
(normalizeStats crash/prototype write), and GHSA-h633-868p-5rfw
(SCOPED_CONFIG__PATTERN ReDoS) — all single-request DoS vectors. This one is
different in character (volumetric, not single-request) and is reported
separately/scored lower accordingly.
Severity
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
browserslist/browserslist (browserslist)
v4.28.7Compare Source
v4.28.6Compare Source
v4.28.5Compare Source
>and>=queries (by @spokodev).v4.28.4Compare Source
SyntaxErrorregression of 4.28.3.v4.28.3Compare Source
v4.28.2Compare Source
v4.28.1Compare Source
v4.28.0Compare Source
v4.27.0Compare Source
BROWSERSLIST_TRACE_WARNINGenvironment variable.v4.26.3Compare Source
throwOnMissingwithextendsquery (by @alexander-akait).v4.26.2Compare Source
baseline-browser-mappingversion requirement.v4.26.1Compare Source
v4.26.0Compare Source
v4.25.4Compare Source
v4.25.3Compare Source
v4.25.2Compare Source
--permissionsupport (by @broofa).v4.25.1Compare Source
v4.25.0Compare Source
cover 95% in browserslist-config-mycompany statsquery support.v4.24.5Compare Source
v4.24.4Compare Source
v4.24.3Compare Source
v4.24.2Compare Source
caniuse-litewarning text.v4.24.1Compare Source
caniuse-liteupdate to the warning (by @mezhnin).v4.24.0Compare Source
browserslist.findConfigFile()helper (by @JLHwung).v4.23.3Compare Source
>=query forios(by @syi0808).Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.