fix: skip Qt app wrapping for generator to avoid macOS segfault#58
Open
adklempner wants to merge 1 commit intologos-co:masterfrom
Open
fix: skip Qt app wrapping for generator to avoid macOS segfault#58adklempner wants to merge 1 commit intologos-co:masterfrom
adklempner wants to merge 1 commit intologos-co:masterfrom
Conversation
The logos-cpp-generator is a build-time CLI tool that uses Qt Remote Objects for code generation. It doesn't need QT_PLUGIN_PATH or other runtime env vars injected by wrapQtAppsNoGuiHook. On some macOS versions, the wrapQtApp step segfaults (exit code 139) during the fixup phase when the Darwin binary wrapper tooling encounters the generator binary. Setting dontWrapQtApps = true skips this step entirely, fixing the build on affected systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logos-cpp-generator is a build-time CLI tool that uses Qt Remote Objects for code generation. It doesn't need QT_PLUGIN_PATH or other runtime env vars injected by wrapQtAppsNoGuiHook.
On some macOS versions, the wrapQtApp step segfaults (exit code 139) during the fixup phase when the Darwin binary wrapper tooling encounters the generator binary. Setting dontWrapQtApps = true skips this step entirely, fixing the build on affected systems.