Use proper retrofit2 async execution#6
Open
linakis wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
In Retrofit 2 the Interface definition is the same for synchronous and asynchronous requests. It's up to the execution |
Contributor
Author
|
Any news on this? |
Contributor
Author
|
@tony19 any updates on this pull request? it's pretty straightforward. Since retrofit 2.2.0 proguard complaints and production release fails. |
|
hey @linakis thank you for the patch. Saved my day 👍 too bad loggly does not maintain this library anymore. |
Contributor
Author
|
@anthony-skr glad I helped. I've actually made some enhancements for a project I'm currently working on and probably will publish them once I'm sure they are stable. |
sanitize tags from invalid characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new asynchronous
Callinstead of the oldCallbackway