adds: file protocol for snapshot and restore#3928
Conversation
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7233cc1034
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6238a83ace
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Stream the local file into the syncer PVC via exec before pausing. | ||
| // The PVC (and the staged file) persist through scale-to-zero. |
There was a problem hiding this comment.
When restoring a file:// snapshot for a non-standalone vCluster whose /data volume is not a PVC, this upload is lost before the restore pod starts: runRestorePod pauses/scales the vCluster after the file is written, and the chart can render the control plane as a Deployment without persistence (chart/templates/_persistence.tpl lines 4-5) where data is an emptyDir (chart/templates/statefulset.yaml lines 119-121). In that environment the subsequent restore pod gets a fresh /data, so file:///data/vcluster-restore-...tar.gz does not exist and local-file restore fails; stage the file somewhere that survives the pause or stream it into the restore pod instead.
Useful? React with 👍 / 👎.
jjaferson
force-pushed
the
ENGCP-427
branch
2 times, most recently
from
e606f97 to
6fe5d13
Compare
1 participant
What issue type does this pull request address? (keep at least one, remove the others)
kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENGCP-427
Please provide a short message that should be published in the vcluster release notes
Adds a file protocol for snapshot and restore feature to enable users to use the filesystem as a backing storage
What else do we need to know?
E2E Tests
Default Test Execution
The mandatory PR suite runs automatically. Only specify additional test suites below if needed.
Adding New Test Suites
When adding a new ginkgo test suite:
Additional test suites
Additional test suite(s) that will be executed before the mandatory PR suite: