feat: uptake etcd v3 snapshot facilities for embedded etcd#3907
Conversation
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
3 times, most recently
from
c07ab8b to
b160493
Compare
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
from
4976cec to
7b06eac
Compare
mfranczy
left a comment
mfranczy
left a comment
There was a problem hiding this comment.
As agreed at the meeting, please review if we can safely modify the bbolt db offline, in the meantime I will take a closer look into the peers problem.
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
from
519d2e9 to
276f25c
Compare
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
from
a597930 to
77af521
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08c46e2a17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
6 times, most recently
from
d6f16fb to
608eb22
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 608eb225fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
3 times, most recently
from
3218542 to
b70942c
Compare
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
from
0314be6 to
0eed315
Compare
cbalan
force-pushed
the
engcp-655-uptake-etcd-v3-snapshot-restore-facilities-for-vcluster
branch
from
0eed315 to
b227700
Compare
3 participants
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Part of #ENGCP-655
Please provide a short message that should be published in the vcluster release notes
Introduce native etcd v3 snapshot/restore for embedded etcd via etcdutl, while preserving the existing key-value tar-stream approach for other backing stores (SQLite, deployed/external etcd).
What else do we need to know?
E2E Tests
Default Test Execution
The mandatory PR suite runs automatically. Only specify additional test suites below if needed.
Adding New Test Suites
When adding a new ginkgo test suite:
Additional test suites
Additional test suite(s) that will be executed before the mandatory PR suite: