Skip to content

Implement DeleteAllOf in blockingcacheclient and pluginhookclient#3607

Open
behrooz wants to merge 1 commit into
loft-sh:mainfrom
behrooz:fix/delete-all-of-implementation
Open

Implement DeleteAllOf in blockingcacheclient and pluginhookclient#3607
behrooz wants to merge 1 commit into
loft-sh:mainfrom
behrooz:fix/delete-all-of-implementation

Conversation

@behrooz
Copy link
Copy Markdown

@behrooz behrooz commented Feb 26, 2026

What does this PR do?

Implements DeleteAllOf explicitly on the wrapper clients so the previously unimplemented method is no longer a TODO.

Changes

  • pkg/util/blockingcacheclient/client.go: Add DeleteAllOf that delegates to the embedded client.Client. Removes the // TODO: implement DeleteAllOf comment.
  • pkg/util/pluginhookclient/client.go: Add DeleteAllOf that delegates to the embedded client.Client. Removes the // TODO: implement DeleteAllOf comment.

Behavior

No behavior change. Both wrappers already exposed the embedded client’s DeleteAllOf via struct embedding. This makes that behavior explicit and resolves the TODOs.

@behrooz behrooz requested a review from a team as a code owner February 26, 2026 13:27
@flomedja
Copy link
Copy Markdown
Contributor

As you said both structs already get DeleteAllOf promoted from their embedded client.Client field. If we want to implement DeleteAllOf to be compliant with the Delete implementation that will require cache-blocking and check for pluginHooks on a group of objects present in the cache.
IMHO just calling the wrapped function have no real value however I agree that we could make the TODO comment more explicit for a future implementation.

WDYT @FabianKramm

@FabianKramm
Copy link
Copy Markdown
Member

Totally agree here @flomedja, this PR doesn't really improve the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants