Implement DeleteAllOf in blockingcacheclient and pluginhookclient#3607
Open
behrooz wants to merge 1 commit into
Open
Implement DeleteAllOf in blockingcacheclient and pluginhookclient#3607behrooz wants to merge 1 commit into
behrooz wants to merge 1 commit into
Conversation
Contributor
|
As you said both structs already get WDYT @FabianKramm |
Member
|
Totally agree here @flomedja, this PR doesn't really improve the situation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements
DeleteAllOfexplicitly on the wrapper clients so the previously unimplemented method is no longer a TODO.Changes
DeleteAllOfthat delegates to the embeddedclient.Client. Removes the// TODO: implement DeleteAllOfcomment.DeleteAllOfthat delegates to the embeddedclient.Client. Removes the// TODO: implement DeleteAllOfcomment.Behavior
No behavior change. Both wrappers already exposed the embedded client’s
DeleteAllOfvia struct embedding. This makes that behavior explicit and resolves the TODOs.