Skip to content

Added a unit test for cypher text padding check in client's symmetric_decrypt_verify() #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BogdanYarotsky wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added a unit test for cypher text padding check in client's symmetric_decrypt_verify() #381

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d853f0d
removed commented out code in symmetric_decrypt_verify
BogdanYarotsky Sep 13, 2024
95088bc
Revert "removed commented out code in symmetric_decrypt_verify"
BogdanYarotsky Sep 22, 2024
792ad25
uncommented the code responsible for ciphertext padding check
BogdanYarotsky Sep 22, 2024
8b9d59b
added a unit test to validate padding check in symmetric_decrypt_and_…
BogdanYarotsky Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions lib/src/core/comms/secure_channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1209,13 +1209,7 @@ impl SecureChannel {
}
MessageSecurityMode::SignAndEncrypt => {
self.expect_supported_security_policy();

// There is an expectation that the block is padded so, this is a quick test
let ciphertext_size = encrypted_range.end - encrypted_range.start;
// if ciphertext_size % 16 != 0 {
// error!("The cipher text size is not padded properly, size = {}", ciphertext_size);
// return Err(StatusCode::BadUnexpectedError);
// }

// Copy security header
dst[..encrypted_range.start].copy_from_slice(&src[..encrypted_range.start]);
Expand All @@ -1235,7 +1229,6 @@ impl SecureChannel {
&mut decrypted_tmp[..],
)?;

// Self::log_crypto_data("Encrypted buffer", &src[..encrypted_range.end]);
let encrypted_range =
encrypted_range.start..(encrypted_range.start + decrypted_size);
dst[encrypted_range.clone()].copy_from_slice(&decrypted_tmp[..decrypted_size]);
Expand Down