Skip to content

Simplifed signed signature verification #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BogdanYarotsky wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Simplifed signed signature verification #380

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1535bfa
simplifed signed signature verification
BogdanYarotsky Sep 13, 2024
5d5eb6f
updated signature veryfing trace message (same as in decrypt match arm)
BogdanYarotsky Sep 13, 2024
4514d49
removed redundant reference
BogdanYarotsky Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions lib/src/core/comms/secure_channel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,21 +1188,20 @@ impl SecureChannel {
}
MessageSecurityMode::Sign => {
self.expect_supported_security_policy();
// Copy everything
let all = ..src.len();
trace!("copying from slice {:?}", all);
dst[all].copy_from_slice(&src[all]);
dst.copy_from_slice(src);

// Verify signature
let signature_range = signed_range.end..src.len();
let verification_key = self.verification_key();
trace!(
"Verifying range from {:?} to signature {}..",
"signed range = {:?}, signature range = {:?}",
signed_range,
signed_range.end
signature_range
);
let verification_key = self.verification_key();
self.security_policy.symmetric_verify_signature(
verification_key,
&dst[signed_range.clone()],
&dst[signed_range.end..],
&dst[signed_range],
&dst[signature_range],
)?;

Ok(encrypted_range.end)
Expand Down