Skip to content

Autofocus of reply textarea does not work when replying to a comment #181

Description

@dssjoblom

The autofocusing code does not work when replying to a comment, it only works when creating a new comment. The code in _new.js.erb is:

<%
  id = @comment.parent.nil? ? "commontator-thread-#{@commontator_thread.id}-new-comment" :
                              "commontator-comment-#{@comment.parent.id}-reply"
%>

$('#<%= id %>-body').focus();

And in _form.html.erb, the id is set as follows:

      form.text_area :body, rows: '7', id: new_record ?
        comment.parent.nil? ? "commontator-thread-#{@commontator_thread.id}-new-comment-body" :
                              "commontator-comment-#{comment.parent.id}-reply" :
        "commontator-comment-#{comment.id}-edit-body"

There are two problems: 1. if comment.parent is not nil, the id will not end in -body, hence it won't get focus 2. without the -body suffix, the id is actually a duplicate of another id, breaking e.g. id selectors.

My quick fix is to change _form.html.erb so that it reads:

      form.text_area :body, rows: '7', id: new_record ?
        comment.parent.nil? ? "commontator-thread-#{@commontator_thread.id}-new-comment-body" :
                              "commontator-comment-#{comment.parent.id}-reply-body" :
        "commontator-comment-#{comment.id}-edit-body"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions