don't emit redundant write_en = 0 for seq_mem#10174
Open
Abhilekhgautam wants to merge 1 commit intollvm:mainfrom
Open
don't emit redundant write_en = 0 for seq_mem#10174Abhilekhgautam wants to merge 1 commit intollvm:mainfrom
Abhilekhgautam wants to merge 1 commit intollvm:mainfrom
Conversation
Abhilekhgautam
requested review from
andrewb1999,
cgyurgyik,
jiahanxie353 and
rachitnigam
as code owners
Member
|
Has this been tested through the native compiler at all, per Rachit's comment? I'm still skeptical that undriven wires will default to zero for all Calyx backends. |
Member
|
(...and I acknowledge perhaps that should be a backend-specific requirement.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10074