[Verif] Preserve labeled assert/assume ops during canonicalization#10114
Open
fabianschuiki wants to merge 1 commit intomainfrom
Open
[Verif] Preserve labeled assert/assume ops during canonicalization#10114fabianschuiki wants to merge 1 commit intomainfrom
fabianschuiki wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
Member
|
Just get some data from internal designs on this. This was put in specifically to start squashing input only modules. See what you dig up from the internal data. |
The EraseIfEnableFalse and EraseIfPropertyTrue canonicalization patterns unconditionally erased verif.assert and verif.assume ops (and their clocked variants) when they were trivially true or disabled. This silently dropped user-visible labels that users expect to see in the output regardless of optimizations. Instead of erasing labeled ops, replace them with trivially-satisfied versions that preserve the label: set the property to constant true, clear the enable, and for clocked ops replace a non-constant clock with constant false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fabianschuiki
force-pushed
the
fschuiki/preserve-labeled-asserts
branch
from
55479f4 to
4627696
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EraseIfEnableFalse and EraseIfPropertyTrue canonicalization patterns unconditionally erased verif.assert and verif.assume ops (and their clocked variants) when they were trivially true or disabled. This silently dropped user-visible labels that users expect to see in the output regardless of optimizations.
Instead of erasing labeled ops, replace them with trivially-satisfied versions that preserve the label: set the property to constant true, clear the enable, and for clocked ops replace a non-constant clock with constant false.