Open
Conversation
…the evolving stage solution, as requested during PR review
…ep and when 'Reset' will be called thereafter
…fixed step and when 'Reset' will be called thereafter" This reverts commit 33380c2.
Co-authored-by: David Gardner <gardner48@llnl.gov>
This PR * Replaces `PreProcessStep` with `PreStepFn` -- removes "process" from the name, adds the current step and attempt index as inputs, and always call before a step attempt * Removes `PostProcessStepFail` -- users can handle this case by checking the attempt index in `PreProcessStep` * Replaces `PostProcessStep` call in `arkCompleteStep` with a `PostStepFn` * Replaces `PostProcessStage` calls on the new state in `TakeStep` functions with `PostProcessStep` calls and account cases where the last stage is the new state * Replaces `PreRHSProcess` with `PreRhsFn` to remove the idea of processing from the name
Co-authored-by: Mustafa Ağgül <33010171+maggul@users.noreply.github.com>
…ur, and removed changes that increased cost
…ls into feature/fes-tstop-adaptivity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional routines to the SUNDIALS time integrators so that time steps which are shortened to adhere to "stop time" requests will be disregarded from the time step and method order adaptivity processes.
This feature is disabled by default; if after extensive testing we wish to enable this by default, I recommend that this wait until the next major release.