Fix UILabel TextKit truncation hit testing - #75
Open
krysto9872 wants to merge 2 commits into
Open
Conversation
Keep TextKit's final-line truncation aligned with UILabel when numberOfLines is limited, and prevent taps on hidden truncated glyphs from triggering actions. Preserve paragraph wrapping for truncating modes and synchronize label layout metrics.
Keep scaled UILabel baseline, line-height, and paragraph spacing calculations consistent with the TextKit layout used for hit testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the remaining mismatch between UILabel truncation and TextKit hit testing when
numberOfLinesis limited.Changes
truncatedGlyphRange, preventing hidden action ranges from firing.Verification
git diff --checkpasses locally.Related to #12 and follows the truncation concern raised in #74.